Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-introduce subfeatures for MathML attributes superscriptshift/subsc… #17962

Merged
merged 4 commits into from Oct 10, 2022

Conversation

fred-wang
Copy link
Contributor

Summary

Re-introduce subfeatures for MathML attributes superscriptshift/subscriptshift. These were incorrectly removed in [3]. Actually, they were disabled in Firefox in [1] and implemented in WebKit in [2]. Also make mirror Safari iOS mirror Safari (they have the same MathML support).

Test results and supporting details

[1] https://bugzilla.mozilla.org/show_bug.cgi?id=1664488
[2] https://commits.webkit.org/139551@main

Related issues

[3] #17617

…riptshift

Re-introduce subfeatures for MathML attributes superscriptshift/subscriptshift.
These were incorrectly removed in [1]. Actually, they were disabled in Firefox in [2] and implemented in WebKit in [3].
Also make mirror Safari iOS mirror Safari (they have the same MathML support).

[1] mdn#17617
[2] https://bugzilla.mozilla.org/show_bug.cgi?id=1664488
[3] https://commits.webkit.org/139551@main
@github-actions github-actions bot added the data:mathml ➗ Compat data for MathML features. https://developer.mozilla.org/docs/Web/MathML label Oct 8, 2022
@fred-wang
Copy link
Contributor Author

cc @Elchi3

"opera": "mirror",
"opera_android": "mirror",
"safari": {
"version_added": false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Safari is false here and for superscriptshift ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's a mistake

fred-wang added a commit to fred-wang/content that referenced this pull request Oct 10, 2022
…hift.

Document deprecated MathML attributes superscriptshift/subscriptshift. These were incorrectly removed in [3]. Actually, they were disabled in Firefox in [1] and implemented in WebKit in [2]. See also [4].

[1] https://bugzilla.mozilla.org/show_bug.cgi?id=1664488
[2] https://commits.webkit.org/139551@main
[3] mdn@21f8488
[4] mdn/browser-compat-data#17962
@fred-wang fred-wang requested a review from Elchi3 October 10, 2022 09:42
"opera": "mirror",
"opera_android": "mirror",
"safari": {
"version_added": "9"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this 9 and all other safari versions are 7?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be 7 too. Sorry...

Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

@Elchi3 Elchi3 merged commit 9441fa0 into mdn:main Oct 10, 2022
Elchi3 pushed a commit to mdn/content that referenced this pull request Oct 10, 2022
…hift. (#21452)

Document deprecated MathML attributes superscriptshift/subscriptshift. These were incorrectly removed in [3]. Actually, they were disabled in Firefox in [1] and implemented in WebKit in [2]. See also [4].

[1] https://bugzilla.mozilla.org/show_bug.cgi?id=1664488
[2] https://commits.webkit.org/139551@main
[3] 21f8488
[4] mdn/browser-compat-data#17962
@fred-wang fred-wang deleted the revert-script-shift branch October 10, 2022 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:mathml ➗ Compat data for MathML features. https://developer.mozilla.org/docs/Web/MathML
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants