Improve ZoomSettings data #17966
Merged
Improve ZoomSettings data #17966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
data:webext 🎲
rebloor
requested changes
Oct 11, 2022
Co-authored-by: rebloor <git@sherpa.co.nz>
rebloor
approved these changes
Oct 17, 2022
|
Many thanks @gregorypappas |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In bug 1772166 I am updating Firefox's implementation of defaultZoomFactor to align with other browsers, I would like to document these changes on MDN.
Test results and supporting details
Firefox's current implementation, which is hardcoded to always return
1https://searchfox.org/mozilla-central/rev/6f006e854adf794a7e17c136662d69d81cb6ca97/browser/components/extensions/parent/ext-tabs.js#1233