Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FF101 CSS scroll() function on animation_timeline #18064

Merged
merged 3 commits into from Oct 28, 2022

Conversation

hamishwillee
Copy link
Collaborator

@hamishwillee hamishwillee commented Oct 24, 2022

FF101 added support for the scroll() CSS functional notation in https://bugzilla.mozilla.org/show_bug.cgi?id=1737918 behind a preference.

I haven't added data for one of these before, but the scroll() appears to only be applicable on an animation-timeline as an option, so I have added it there. I would have made the "key" into scroll() but the linter wouldn't let me, so I followed the pattern of font-variant-alternates and used the description to clarify it as a function - that OK?

Other docs work for this can be tracked in mdn/content#15467

FYI @queengooborg

@github-actions github-actions bot added the data:css 🎨 Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS label Oct 24, 2022
@hamishwillee
Copy link
Collaborator Author

@queengooborg Can we please merge this?

@hamishwillee
Copy link
Collaborator Author

Note, Chrome also implements this behind a preference, but I don't know how to work out what that preference IS - the associated bug is https://bugs.chromium.org/p/chromium/issues/detail?id=1317765

@queengooborg
Copy link
Collaborator

Note, Chrome also implements this behind a preference, but I don't know how to work out what that preference IS - the associated bug is https://bugs.chromium.org/p/chromium/issues/detail?id=1317765

It might actually not -- https://bugs.chromium.org/p/chromium/issues/detail?id=1317765#c53 says that "Making animation-delay a shorthand based on a runtime flag is a bit complicated since our code generation does not support it. That work is therefore deferred to a later CL." But it's not a big concern to me to research, if someone else wants to dig deeper and make a PR, I won't say no! ;P

@queengooborg queengooborg merged commit 448f27d into mdn:main Oct 28, 2022
@hamishwillee hamishwillee deleted the animation_timeline_scroll branch October 31, 2022 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:css 🎨 Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants