Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update compatibility for web globals on Node.js #18035 #18076

Merged
merged 24 commits into from Oct 25, 2022

Conversation

Richienb
Copy link
Contributor

Summary

Node.js 18 and 19 have exposed new web features as globals.

https://nodejs.org/api/globals.html

@Richienb Richienb marked this pull request as draft October 25, 2022 07:04
@github-actions github-actions bot added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Oct 25, 2022
@Richienb Richienb marked this pull request as ready for review October 25, 2022 07:06
@github-actions github-actions bot added the data:browsers 🌍 Data about browsers (versions, release dates, etc). This data is used for validation. label Oct 25, 2022
@Richienb
Copy link
Contributor Author

CI is failing with:

nodejs has multiple current releases (18.0.0, 19.0.0), which is not allowed.

This is inaccurate, see https://github.com/nodejs/Release/blob/0573a2f6e65c2cafa73f0d0a20ce1637d40e3285/README.md#release-schedule

@Richienb
Copy link
Contributor Author

Richienb commented Oct 25, 2022

Node.js 18 enters Active Maintenance in about 24 hours, so I updated the information so that the CI passes.

@teoli2003 teoli2003 merged commit 10cdcbe into mdn:main Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API data:browsers 🌍 Data about browsers (versions, release dates, etc). This data is used for validation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants