Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add InkPresenter interface #18092

Merged
merged 1 commit into from Oct 27, 2022

Conversation

chrisdavidmills
Copy link
Collaborator

Summary

This PR adds the Ink API's InkPresenter interface to BCD.

Test results and supporting details

The other features of the API were already in BCD, so I just copied the support data from them. It looks fairly accurate tho — the Chrome folks have confirmed to me that it is definitely supported in Chrome 94 and above, and I also tested it in Edge and found it to be working

See Enhancing Inking on the Web for more explanation and a demo.

Related issues

@github-actions github-actions bot added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Oct 27, 2022
},
"chrome_android": "mirror",
"edge": {
"version_added": "93"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is weird. How is it that the Edge version is before the Chrome version? (Here and for the other ink).

@queengooborg Can we test this?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a bit strange...maybe it should just be 94.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Microsoft led the development of Ink APIs so Edge getting the feature early actually does make sense. I think the latest mdn-bcd-collector version has the IDL for this interface, so if desired, we can confirm the data through it!

(By the way, welcome back Chris, it's great to see you again!)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(By the way, welcome back Chris, it's great to see you again!)

👋 ❤️ !

Nice to see you too ;-)

Copy link
Member

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think your explanation… explain why. Thanks @queengooborg

@teoli2003 teoli2003 merged commit 49fa9d2 into mdn:main Oct 27, 2022
@chrisdavidmills chrisdavidmills deleted the add-missing-ink-api-features branch October 28, 2022 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants