New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Link header specification #18126
Conversation
Added Link header specification, as references used the [test page](https://early-hints.fastlylabs.com/), [chromium docs](https://chromium.googlesource.com/chromium/src/+/master/docs/early-hints.md#using-origin-trial) and [RFC8288](https://httpwg.org/specs/rfc8288.html#header).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there, thank you for your PR and welcome to BCD!
I'm unable to verify that the test actually works properly, as the test states that it passes as far back as Chrome 30 and Firefox 32. This doesn't match what Chrome Status reports, nor the documentation you've linked, and it appears that the test is just bad altogether because it doesn't actually test for the status code's support in browsers:
Passing means that the client doesn't break when receiving a non-final status code like 103; it doesn't mean that they'll actually do anything with the hints.
But regardless of the test's functionality, if ChromeStatus says 103 then I'll go with that number. 👍 We can also mirror this to Edge (since it's a Chromium fork) and set IE to false
because there's no way that IE can support a new feature like this!
Co-authored-by: Queen Vinyl Da.i'gyu-Kazotetsu <vinyldarkscratch@gmail.com>
Hi @queengooborg, thanks for the review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick response and changes, this is LGTM!
Summary
Added Link header specification, based on RFC8288 and to be used with 103 Early Hint status.
RFC8288 added in browser-specs@3.32.0
Test results and supporting details
As references used the test page, chromium docs and RFC8288.
Related issues