New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add MSE in workers data #18189
add MSE in workers data #18189
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
@queengooborg yay! ❤️ |
These are not supported in Chrome yet (their implementation is incomplete and experimental, behind the blink::RuntimeEnabledFeature "AudioVideoTracks" which is marked experimental still):
And Chrome does not have support at all for |
Also, for at least the "MediaSource" (https://developer.mozilla.org/en-US/docs/Web/API/MediaSource) page, there are two "Available in workers" rows of BCD table data at the very bottom, with none following the ctor at the top - was one of those two rows meant for the ctor, or was it extra - it's confusing to me. |
Is it true that MSE-in-Workers is available in Opera 93? I looked at that changelog and it didn't indicate anything to me on skimming it that related to MSE-in-Workers. I ask because the BCD table for at least MediaSource has Opera version 93 as the version supporting MSE-in-Workers. |
Please revert the portion of this BCD data that is specific to VideoPlaybackQuality: that portion of the API is specific to the HTMLMediaElement, which itself is only available on the main thread context. There is no worker HTMLMediaElement in Chrome (or on any browser); only a main thread/context HTMLMediaElement. It's unfortunate that originally MSE specification was used to get VideoPlaybackQuality specified (I think it was due to spec workgroups being more amenable in W3C for this change at the time long ago). More recently, the VideoPlaybackQuality specification (Media Playback Quality, as referenced on MDN) is precise about this API only being exposed on Window context (not worker). |
Hi @wolenetz -- rather than comment on an already-merged pull request, would you mind opening a new issue and linking to this PR instead? This will allow us to better track what potentially needs to be done to correct the data, as threads on closed PRs will most certainly get lost in everyone's inboxes and forgotten. :) |
I filed #18220 |
Summary
This PR adds the required new BCD for Chrome's additions to Media Source Extensions, which allows them to be used from inside dedicated workers.
See my research document for more details: https://docs.google.com/document/d/1_zwIr7c9_O3_PEoAnaS5M7yExx9VtjMSUJ6U5yiEias/edit#
Notes
SourceBuffer.audioTracks
SourceBuffer,textTracks
SourceBuffer.videoTracks
SourceBuffer.appendBufferAsync
- experimental Fx feature?SourceBuffer.appendStream
- experimental feature supported in pre-Chromium Edge?SourceBuffer.removeAsync
- experimental Fx feature?