Add idle-detection to http.headers.Feature-Policy
#18196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The data here is cribbed from the `IdleDetector` features, but I did a little independent verification via: https://chromestatus.com/feature/4590256452009984 https://storage.googleapis.com/chromium-find-releases-static/487.html#487196e61e193ee2511231e3cbe4229c26687ec2
github-actions
bot
added
the
data:http 🚠
lucalves
approved these changes
Nov 13, 2022
| "chrome_android": "mirror", | ||
| "edge": { | ||
| "version_added": "94", | ||
| "version_removed": "96" |
There was a problem hiding this comment.
Where did this version_removed come from? Could you link the source for this?
There was a problem hiding this comment.
You're the source for this: #16222 (comment)
There was a problem hiding this comment.
Ah right! Thanks for the link!
queengooborg
approved these changes
Nov 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Complete the features required to represent all of the features implied by the Idle Detection spec.
Test results and supporting details
I didn't actually test this. The data here is cribbed from the existing
api.IdleDetectorfeatures, but I did a little independent verification via:Related issues
idle-detectionis enabled for both PP and FP, so this PR is merely incomplete, not wrong.