Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add html.manifest.id BCD #18197

Merged
merged 5 commits into from Nov 19, 2022
Merged

Conversation

dawei-wang
Copy link
Contributor

Fixes #18192

Summary

Test results and supporting details

Related issues

@github-actions github-actions bot added the data:html 📄 Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML label Nov 11, 2022
Copy link
Collaborator

@queengooborg queengooborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR, and welcome to BCD! The sources that are linked in the issue LGTM for Chrome and Firefox. For the other Chromium forks, we can just mirror their data.

html/manifest/id.json Outdated Show resolved Hide resolved
html/manifest/id.json Outdated Show resolved Hide resolved
html/manifest/id.json Outdated Show resolved Hide resolved
dawei-wang and others added 3 commits November 16, 2022 17:35
Co-authored-by: Queen Vinyl Da.i'gyu-Kazotetsu <vinyldarkscratch@gmail.com>
Co-authored-by: Queen Vinyl Da.i'gyu-Kazotetsu <vinyldarkscratch@gmail.com>
Co-authored-by: Queen Vinyl Da.i'gyu-Kazotetsu <vinyldarkscratch@gmail.com>
@dawei-wang
Copy link
Contributor Author

@queengooborg Sounds good, I have committed the suggested changes.

Copy link
Collaborator

@queengooborg queengooborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this is LGTM!

@queengooborg queengooborg merged commit fc12d0e into mdn:main Nov 19, 2022
@dawei-wang dawei-wang deleted the add-web-manifests-id-member branch November 29, 2022 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:html 📄 Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add html.manifest.id
2 participants