Update return value entry for performance.measure #18216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
data:api 🐇
queengooborg
approved these changes
Nov 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates https://developer.mozilla.org/en-US/docs/Web/API/Performance/measure#browser_compatibility to change from "Returns undefined" to "Returns PerformanceMeasure". I think it is backwards to talk about undefined as the return value here.
Test results and supporting details
Firefox implemented "Returns PerformanceMeasure" in 103: https://hg.mozilla.org/mozilla-central/rev/2d93cc964b79
Safari implemented "Returns PerformanceMeasure" in Preview 114: https://webkit.org/blog/11333/release-notes-for-safari-technology-preview-115/ ("Update User Timing interfaces to User Timing Level 3"). 114 is in Safari 14.1 per https://webkit.org/blog/11648/new-webkit-features-in-safari-14-1/
Related issues
This was introduced in #13478