Add missing api.NDEFReader.makeReadOnly feature #18279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR is a part of a project to add missing interfaces and interface features to BCD that are from an active spec (including WICG specs) and is supported in at least one browser. This particular PR adds the missing `makeReadOnly` member of the NDEFReader API. Tests Used: https://mdn-bcd-collector.gooborg.com/tests/api/NDEFReader/makeReadOnly _Check out the [collector's guide on how to review this PR](https://github.com/GooborgStudios/mdn-bcd-collector#reviewing-bcd-changes)._
queengooborg
added
the
data:api 🐇
foolip
reviewed
Nov 25, 2022
api/MIDIOutputMap.json
Outdated
| @@ -376,6 +376,38 @@ | |||
| "deprecated": false | |||
| } | |||
| } | |||
| }, | |||
| "@@iterator": { | |||
There was a problem hiding this comment.
Oops, this shouldn't be in this PR. I'll revert.
|
@queengooborg looks like |
foolip
approved these changes
Nov 25, 2022
|
Oops, I'll take care of MIDIOutputMap during the next wave of BCD additions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a part of a project to add missing interfaces and interface features to BCD that are from an active spec (including WICG specs) and is supported in at least one browser. This particular PR adds the missing
makeReadOnlymember of the NDEFReader API.Tests Used: https://mdn-bcd-collector.gooborg.com/tests/api/NDEFReader/makeReadOnly
Check out the collector's guide on how to review this PR.