Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CSS] Implement font-variant-emoji #18381

Merged
merged 2 commits into from Dec 7, 2022
Merged

Conversation

dletorey
Copy link
Contributor

@dletorey dletorey commented Dec 6, 2022

Summary

Added the BCD for font-variant-emoji and also to font-variant

Test results and supporting details

Tested in firefox nightly and firefox with the flag, being released in firefox 108. Other browsers currently have on plans to support this

Related issues

mdn/content#22118

@github-actions github-actions bot added the data:css 🎨 Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS label Dec 6, 2022
@dletorey dletorey changed the title 22118 [CSS] Implement font-variant-emoji #22118 Dec 6, 2022
@queengooborg queengooborg changed the title [CSS] Implement font-variant-emoji #22118 [CSS] Implement font-variant-emoji Dec 7, 2022
@dipikabh
Copy link
Contributor

dipikabh commented Dec 8, 2022

Hi @dletorey, in the BCD table for the 108 release, would we need to add the preference setting (layout.css.font-variant-emoji.enabled) for this property? Something along the lines of https://developer.mozilla.org/en-US/docs/Web/CSS/align-tracks#browser_compatibility.

Also, the spec URLs would need to be updated with:

queengooborg added a commit to queengooborg/browser-compat-data that referenced this pull request Jun 16, 2023
This PR updates and corrects version values for Firefox and Firefox Android for the `font-variant-emoji` CSS property. The data comes from the [mdn-bcd-collector](https://mdn-bcd-collector.gooborg.com) project (v10.0.1).

_Check out the [collector's guide on how to review this PR](https://github.com/GooborgStudios/mdn-bcd-collector#reviewing-bcd-changes)._

Tests Used: https://mdn-bcd-collector.gooborg.com/tests/css/properties/font-variant-emoji

Additional Notes: This is a follow-up to mdn#18381, which set Firefox as supported but did not include the required flag data (which Dipika later pointed out).
Elchi3 pushed a commit that referenced this pull request Jun 19, 2023
This PR updates and corrects version values for Firefox and Firefox Android for the `font-variant-emoji` CSS property. The data comes from the [mdn-bcd-collector](https://mdn-bcd-collector.gooborg.com) project (v10.0.1).

_Check out the [collector's guide on how to review this PR](https://github.com/GooborgStudios/mdn-bcd-collector#reviewing-bcd-changes)._

Tests Used: https://mdn-bcd-collector.gooborg.com/tests/css/properties/font-variant-emoji

Additional Notes: This is a follow-up to #18381, which set Firefox as supported but did not include the required flag data (which Dipika later pointed out).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:css 🎨 Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants