New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add compat data for Critical-CH #18389
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, with one question.
We're using https://github.com/w3c/browser-specs to tell what is a real specification. |
Thanks @Elchi3 ! I've filed an issue to ask about this at w3c/browser-specs#788. For now, I wonder if it would be good to merge this as-is, so as not to block the documentation of this feature, and then update the spec info when we have more information? |
Let's wait a day or two. Usually Dom and/or Francois are quick over on w3c/browser-specs :) |
@Elchi3 brilliant, Francois has already added it to browser-specs! I'm assuming I need to wait for BCD to slurp up a new package version? |
Yes sir! Just a few more hours of patience then the new package version will be merged into BCD main and you can rebase this PR to it. Feel free to add the spec_url and flip the standard_track status. |
#18423 has been merged. |
Co-authored-by: Florian Scholz <fs@florianscholz.com>
Co-authored-by: Florian Scholz <fs@florianscholz.com>
Awesome, cheers @Elchi3 ! |
@Elchi3 nice one, thanks mate |
Summary
This PR provides compat-data for the
Critical-CH
HTTP header (see https://chromestatus.com/feature/5727177800679424 for more details).Note: I have had to set this to
"standard_track": false
and remove thespec_url
field, because the linter wouldn't pass it with any of the available specifications for the feature. The spec URLs I found were all archive or experimental versions, e.g. https://www.ietf.org/archive/id/draft-davidben-http-client-hint-reliability-03.txt. Any suggestions would be much appreciated.Test results and supporting details
Related issues