Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add compat data for Critical-CH #18389

Merged
merged 5 commits into from Dec 14, 2022
Merged

Conversation

chrisdavidmills
Copy link
Collaborator

Summary

This PR provides compat-data for the Critical-CH HTTP header (see https://chromestatus.com/feature/5727177800679424 for more details).

Note: I have had to set this to "standard_track": false and remove the spec_url field, because the linter wouldn't pass it with any of the available specifications for the feature. The spec URLs I found were all archive or experimental versions, e.g. https://www.ietf.org/archive/id/draft-davidben-http-client-hint-reliability-03.txt. Any suggestions would be much appreciated.

Test results and supporting details

Related issues

@github-actions github-actions bot added the data:http 🚠 Compat data for HTTP features. https://developer.mozilla.org/docs/Web/HTTP label Dec 7, 2022
Copy link
Contributor

@tomayac tomayac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with one question.

http/headers/Critical-CH.json Outdated Show resolved Hide resolved
@Elchi3
Copy link
Member

Elchi3 commented Dec 8, 2022

Note: I have had to set this to "standard_track": false and remove the spec_url field, because the linter wouldn't pass it with any of the available specifications for the feature. The spec URLs I found were all archive or experimental versions, e.g. https://www.ietf.org/archive/id/draft-davidben-http-client-hint-reliability-03.txt. Any suggestions would be much appreciated.

We're using https://github.com/w3c/browser-specs to tell what is a real specification.
We also have a few exceptions: https://github.com/mdn/browser-compat-data/blob/main/test/linter/test-spec-urls.ts#L15 It is possible to add exceptions so that our linter passes, but usually we first file an issue with https://github.com/w3c/browser-specs to ask why a particular spec isn't included (yet) or if there is a better URL to use.

@chrisdavidmills
Copy link
Collaborator Author

Thanks @Elchi3 ! I've filed an issue to ask about this at w3c/browser-specs#788.

For now, I wonder if it would be good to merge this as-is, so as not to block the documentation of this feature, and then update the spec info when we have more information?

@Elchi3
Copy link
Member

Elchi3 commented Dec 12, 2022

Let's wait a day or two. Usually Dom and/or Francois are quick over on w3c/browser-specs :)
Otherwise you will need to update this PR to add the spec to BCD's exception list: https://github.com/mdn/browser-compat-data/blob/main/test/linter/test-spec-urls.ts#L15

@chrisdavidmills
Copy link
Collaborator Author

@Elchi3 brilliant, Francois has already added it to browser-specs!

I'm assuming I need to wait for BCD to slurp up a new package version?

@Elchi3
Copy link
Member

Elchi3 commented Dec 13, 2022

Yes sir! Just a few more hours of patience then the new package version will be merged into BCD main and you can rebase this PR to it. Feel free to add the spec_url and flip the standard_track status.

@Elchi3
Copy link
Member

Elchi3 commented Dec 14, 2022

#18423 has been merged.

http/headers/Critical-CH.json Outdated Show resolved Hide resolved
http/headers/Critical-CH.json Show resolved Hide resolved
chrisdavidmills and others added 2 commits December 14, 2022 11:24
Co-authored-by: Florian Scholz <fs@florianscholz.com>
Co-authored-by: Florian Scholz <fs@florianscholz.com>
@chrisdavidmills
Copy link
Collaborator Author

Awesome, cheers @Elchi3 !

@Elchi3 Elchi3 merged commit 5cd2d54 into mdn:main Dec 14, 2022
@chrisdavidmills chrisdavidmills deleted the critical-ch-header branch December 14, 2022 11:39
@chrisdavidmills
Copy link
Collaborator Author

@Elchi3 nice one, thanks mate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:http 🚠 Compat data for HTTP features. https://developer.mozilla.org/docs/Web/HTTP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants