Add @import layer()
#18461
Merged
Add @import layer()
#18461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
data:css 🎨
This adds a single subfeature to `@import` for the `layer` function. I added a single feature, though I'm not 100% certain if that's the right call. There's also a `layer` keyword that creates an anonymous layer. Conceptually, is this a single function called with or without an argument? Or is this distinctly two features: a keyword and a function? I'm not 100% certain and I'd like a review that addresses that question.
ddbeck
force-pushed
the
add-css-at-rule-import-layer
branch
from
75cc7db
to
a9f4d45
Compare
queengooborg
approved these changes
Dec 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds a single subfeature to
@importfor thelayerfunction.Test results and supporting details
I tested this manually to confirm that it works. This isn't surprising, since it matches the data for
@layer.I added a single feature, though I'm not 100% certain if that's the right call. There's also a
layerkeyword that creates an anonymous layer. The question is: conceptually, is this a single function called with or without an argument? Or is this distinctly two features: a keyword and a function?I'm not 100% certain and I'd like a review that specifically confirms the answer to that question.