Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Firefox data for api.Performance.mark #19905

Merged

Conversation

queengooborg
Copy link
Collaborator

This PR updates and corrects version values for Firefox and Firefox Android for the mark member of the Performance API. The data comes from the mdn-bcd-collector project (v9.2.0).

Check out the collector's guide on how to review this PR.

Tests Used: https://mdn-bcd-collector.gooborg.com/tests/api/Performance/mark

Additional Notes: These were originally set to 103 in #18229, but I think that the commit may have been pulled into an earlier branch.

This PR updates and corrects version values for Firefox and Firefox Android for the `mark` member of the `Performance` API. The data comes from the [mdn-bcd-collector](https://mdn-bcd-collector.gooborg.com) project (v9.2.0).

_Check out the [collector's guide on how to review this PR](https://github.com/GooborgStudios/mdn-bcd-collector#reviewing-bcd-changes)._

Tests Used: https://mdn-bcd-collector.gooborg.com/tests/api/Performance/mark

Additional Notes: These were originally set to 103 in mdn#18229, but I think that the commit may have been pulled into an earlier branch.
@queengooborg queengooborg added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label May 20, 2023
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, the uplift was for 102esr. https://bugzilla.mozilla.org/show_bug.cgi?id=1762482#c18

I can't find a proof it was uplifted to 101. Did you find one?

@queengooborg
Copy link
Collaborator Author

Hmm, there definitely seems to be support in Fx101 when testing in BrowserStack:

Screenshot 2023-05-21 at 03 01 40

Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, let's go with 101 then. Who knows how it was uplifted exactly 🤷

@Elchi3 Elchi3 merged commit 46dfb84 into mdn:main May 21, 2023
3 checks passed
@queengooborg queengooborg deleted the api/Performance/mark/firefox-corrections branch May 21, 2023 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants