Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data for WebAssembly.*Streaming in Node.js #20704

Merged
merged 2 commits into from
Sep 18, 2023

Conversation

nicolo-ribaudo
Copy link
Contributor

Summary

Test results and supporting details

Run node -p "[WebAssembly.compileStreaming, WebAssembly.instantiateStreaming]" in Node.js 18.0 and 18.1.

Implemented in nodejs/node#42701

Related issues

Implemented in nodejs/node#42701. Manually tested that it's present in Node.js 18.1 and not in 18.0.
@github-actions github-actions bot added the data:js 📟 Compat data for JS/ECMAScript features. https://developer.mozilla.org/docs/Web/JavaScript label Sep 14, 2023
Copy link
Collaborator

@queengooborg queengooborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed by https://github.com/nodejs/node/blob/main/doc/changelogs/CHANGELOG_V18.md#2022-05-03-version-1810-current-targos -- just got a small change and then this will be good to go!

javascript/builtins/WebAssembly.json Outdated Show resolved Hide resolved
javascript/builtins/WebAssembly.json Outdated Show resolved Hide resolved
Co-authored-by: Queen Vinyl Da.i'gyu-Kazotetsu <vinyldarkscratch@gmail.com>
Copy link
Collaborator

@queengooborg queengooborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@queengooborg queengooborg merged commit f09272b into mdn:main Sep 18, 2023
4 checks passed
@nicolo-ribaudo nicolo-ribaudo deleted the patch-1 branch September 18, 2023 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:js 📟 Compat data for JS/ECMAScript features. https://developer.mozilla.org/docs/Web/JavaScript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants