-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add back the anchor HTML attribute #22914
Conversation
This reverts mdn#22910 but uses version "preview" instead of "125".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@foolip just one comment for you to consider. Thanks for doing this.
@@ -37,6 +37,39 @@ | |||
} | |||
} | |||
}, | |||
"anchor": { | |||
"__compat": { | |||
"mdn_url": "https://developer.mozilla.org/docs/Web/HTML/Global_attributes/anchor", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO, it would be good to specify the flag information that is needed to use the feature as well:
"flags": [
{
"type": "preference",
"name": "Experimental Web Platform features",
"value_to_set": "Enabled"
}
]
Same with the HTMLElement.anchorElement
property?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done for both.
@@ -122,8 +122,13 @@ | |||
"support": { | |||
"chrome": { | |||
"version_added": "preview", | |||
"partial_implementation": true, | |||
"notes": "Supported on <code>Element</code>, not on <code>HTMLElement</code>" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chrisdavidmills I'm removing this note to be consistent with https://github.com/mdn/browser-compat-data/blob/main/docs/data-guidelines/api.md#when-members-are-moved-down-the-prototype-chain
@mfreed7 I assume that it will end up on the same interface in spec and implementation before this ships. Do you think that will be HTMLElement
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interestingly, this very question is being debated on the spec PR. My guess would be that this ends up staying on HTMLElement
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This reverts #22910 but uses version "preview" instead of "125".