Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link Chrome and Safari bugs for relative rgb() #22960

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

foolip
Copy link
Collaborator

@foolip foolip commented Apr 29, 2024

Notes are originally from #21937.

@github-actions github-actions bot added the data:css 🎨 Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS label Apr 29, 2024
@foolip
Copy link
Collaborator Author

foolip commented Apr 29, 2024

@chrisdavidmills @romainmenke this removes notes added in #21937, can you review?

`rgb(from red 50% 50% 50%)` was tested in Chrome 119 and Safari 16.5
(not 16.4, BrowserStack doesn't have it) and it works.

Notes are from mdn#21937.
@romainmenke
Copy link
Contributor

That is not the right test for those notes 🤔

@romainmenke
Copy link
Contributor

This is a better test : https://codepen.io/romainmenke/pen/bGJJmZx

rgb(from red calc(r - 1) g b)

It tests both that r is of type number and the numeric value of r.

The result is expected to be almost red (254) and not black or white.

But we must not remove those notes, otherwise we make it seem as it was always implemented correctly, which it obviously wasn't :)

Safari is still broken.
Chrome was fixed in 122.

@romainmenke
Copy link
Contributor

romainmenke commented Apr 29, 2024

I've only now read the linked issue where you say that you think these notes are incorrect.
If they were it would make sense to remove them.

But the notes are accurate :)

@foolip
Copy link
Collaborator Author

foolip commented Apr 29, 2024

Thanks @romainmenke! I couldn't find a Chrome bug for this, so I tested the simplest thing I could infer from the note, and that worked. Do you know if there was a Chrome bug for this?

@romainmenke
Copy link
Contributor

romainmenke commented Apr 29, 2024

Do you know if there was a Chrome bug for this?

I know there was one, but not filed by me for this specifically, so I would also have to do a search for "relative color" and crawl through bugs :)

@foolip
Copy link
Collaborator Author

foolip commented Apr 29, 2024

I couldn't find the bug by search, but using https://codepen.io/romainmenke/pen/bGJJmZx I was able to bisect my way to https://crbug.com/41490327 which was indeed fixed in Chrome 122:
https://chromiumdash.appspot.com/commit/5deed17c9f1446cf0a061d7566e552e8e9bddfaf

@foolip
Copy link
Collaborator Author

foolip commented Apr 29, 2024

And https://webkit.org/b/267647 works as a WebKit bug for this I think, even though it's not specifically about RGB.

@foolip foolip changed the title Mark relative rgb() as fully supported in Chrome and Safari Link Chrome and Safari bugs for relative rgb() Apr 29, 2024
@romainmenke
Copy link
Contributor

I am also assuming that WebKit will fix a large range of issues at once, given how far they have fallen behind WPT at this point.

That bug seems relevant enough with that in mind :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:css 🎨 Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants