-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Link Chrome and Safari bugs for relative rgb() #22960
base: main
Are you sure you want to change the base?
Conversation
@chrisdavidmills @romainmenke this removes notes added in #21937, can you review? |
`rgb(from red 50% 50% 50%)` was tested in Chrome 119 and Safari 16.5 (not 16.4, BrowserStack doesn't have it) and it works. Notes are from mdn#21937.
That is not the right test for those notes 🤔 |
This is a better test : https://codepen.io/romainmenke/pen/bGJJmZx
It tests both that The result is expected to be almost red ( But we must not remove those notes, otherwise we make it seem as it was always implemented correctly, which it obviously wasn't :) Safari is still broken. |
I've only now read the linked issue where you say that you think these notes are incorrect. But the notes are accurate :) |
Thanks @romainmenke! I couldn't find a Chrome bug for this, so I tested the simplest thing I could infer from the note, and that worked. Do you know if there was a Chrome bug for this? |
I know there was one, but not filed by me for this specifically, so I would also have to do a search for |
I couldn't find the bug by search, but using https://codepen.io/romainmenke/pen/bGJJmZx I was able to bisect my way to https://crbug.com/41490327 which was indeed fixed in Chrome 122: |
And https://webkit.org/b/267647 works as a WebKit bug for this I think, even though it's not specifically about RGB. |
I am also assuming that WebKit will fix a large range of issues at once, given how far they have fallen behind WPT at this point. That bug seems relevant enough with that in mind :) |
Notes are originally from #21937.