Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rel=noopener compat data for android webview #23076

Merged
merged 3 commits into from
May 30, 2024
Merged

Update rel=noopener compat data for android webview #23076

merged 3 commits into from
May 30, 2024

Conversation

stefanjudis
Copy link
Contributor

Summary

This PR adds compat data for implicit rel=noopener on target=_blank links. The support info comes from chromestatus.

Test results and supporting details

I wasn't able to test it.

Related issues

@github-actions github-actions bot added the data:html 📄 Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML label May 13, 2024
@myfonj
Copy link
Contributor

myfonj commented May 13, 2024

On recent Android 13 with in Twitter app that hopefully uses WebView (detected as "Chrome 124" by whatismybrowser.com) implicit noopener on target="_blank" works correctly; or more precisely navigating to test page https://myfonj.github.io/tst/implicit-noopener-test.html and clicking "no extra attr" produces page that reports "Opener: null".

skyclouds2001
skyclouds2001 reviewed May 13, 2024
View reviewed changes
html/elements/a.json Outdated Show resolved Hide resolved
@myfonj
Copy link
Contributor

myfonj commented May 13, 2024

It would be neat to have a proper test in some older (ideally "88") WebView version, confirming the "88 qualified guess". Or dig up some more authoritative relnotes.

@Elchi3
Copy link
Member

Elchi3 commented May 30, 2024

It would be neat to have a proper test in some older (ideally "88") WebView version, confirming the "88 qualified guess". Or dig up some more authoritative relnotes.

Given https://chromestatus.com/feature/6140064063029248 says WebView 88, I'm going to trust that for now until proven otherwise.

Elchi3
Elchi3 approved these changes May 30, 2024
View reviewed changes
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your pull request! 👍

@Elchi3 Elchi3 merged commit 61e2f8b into mdn:main May 30, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skyclouds2001 skyclouds2001 skyclouds2001 left review comments

@Elchi3 Elchi3 Elchi3 approved these changes

Assignees
No one assigned
Labels
data:html 📄 Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@stefanjudis @myfonj @Elchi3 @skyclouds2001