Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a few impl_urls to help developers learn more when features aren't available #23091

Merged
merged 3 commits into from
May 27, 2024

Conversation

captainbrosset
Copy link
Contributor

@captainbrosset captainbrosset commented May 14, 2024

This is no particular order, and not complete, but hopefully this helps users of BCD like MDN and Can I Use tell a more complete story to web developers wondering why some features they'd like to use are not available.

Summary

This adds a few impl_url fields for these features:

  • CSS Custom Highlight API
  • Picture-in-Picture API
  • requestVideoFrameCallback
  • margin-trim
  • relative color syntax
  • anchor positioning

Test results and supporting details

Found these details by searching through various bug trackers and standard positions.

@github-actions github-actions bot added data:http 🚠 Compat data for HTTP features. https://developer.mozilla.org/docs/Web/HTTP data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API data:css 🎨 Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS labels May 14, 2024
@captainbrosset
Copy link
Contributor Author

Sorry if this is a bit of a big one. To ease reviewing, you can review in 2 steps: first all commits but the last one. And then only the last one. The last commit is about anchor positioning alone, it contains a lot of changes, but they're all the same.

@Elchi3 Elchi3 self-requested a review May 27, 2024 07:33
@Elchi3
Copy link
Member

Elchi3 commented May 27, 2024

The last commit is about anchor positioning alone, it contains a lot of changes, but they're all the same.

Thanks, I'm assuming you added the impl_url to all entries tagged with "web-features:anchor-positioning".

@@ -824,7 +829,8 @@
"opera": "mirror",
"opera_android": "mirror",
"safari": {
"version_added": "17.5"
"version_added": "17.5",
"impl_url": "https://webkit.org/b/262914"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we generally want to have impl_url after the feature shipped but absent a guideline, this is fine.

Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @captainbrosset, looks good to me. 👍

@Elchi3 Elchi3 merged commit 6c10d9c into mdn:main May 27, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API data:css 🎨 Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS data:http 🚠 Compat data for HTTP features. https://developer.mozilla.org/docs/Web/HTTP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants