-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Node.js 14.3/14.8 and fix Node release statuses #7212
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for cherry-picking these changes! Since NodeJS v14 is still in Active LTS, can we mark the most recent v14 version as "esr"?
(Note: I updated the title of this PR since it includes fixes for other NodeJS version statuses.)
browsers/nodejs.json
Outdated
"14.8.0": { | ||
"release_date": "2020-08-11", | ||
"release_notes": "https://nodejs.org/en/blog/release/v14.8.0/", | ||
"status": "retired", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"status": "retired", | |
"status": "esr", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
14.8 is not most recent, 14.15 is. But then we probably don't want to add every version that we'll never use? What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I've generally stuck with the lowest versions for each column on https://node.green/ with some exceptions (such as major versions or support differences undocumented on node.green).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looking good to me!
This reverts commit dd446f5.
A checklist to help your pull request get merged faster:
node -p process.versions.v8