Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Node.js 14.3/14.8 and fix Node release statuses #7212

Merged
merged 3 commits into from
Nov 1, 2020

Conversation

saschanaz
Copy link
Contributor

A checklist to help your pull request get merged faster:

@github-actions github-actions bot added the data:browsers 🌍 Data about browsers (versions, release dates, etc). This data is used for validation. label Oct 31, 2020
@queengooborg queengooborg changed the title Add Node.js 14.3/14.8 Add Node.js 14.3/14.8 and fix Node release statuses Nov 1, 2020
Copy link
Collaborator

@queengooborg queengooborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cherry-picking these changes! Since NodeJS v14 is still in Active LTS, can we mark the most recent v14 version as "esr"?

(Note: I updated the title of this PR since it includes fixes for other NodeJS version statuses.)

"14.8.0": {
"release_date": "2020-08-11",
"release_notes": "https://nodejs.org/en/blog/release/v14.8.0/",
"status": "retired",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"status": "retired",
"status": "esr",

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

14.8 is not most recent, 14.15 is. But then we probably don't want to add every version that we'll never use? What do you think?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I've generally stuck with the lowest versions for each column on https://node.green/ with some exceptions (such as major versions or support differences undocumented on node.green).

Copy link
Collaborator

@queengooborg queengooborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looking good to me!

@queengooborg queengooborg merged commit dd446f5 into mdn:master Nov 1, 2020
@saschanaz saschanaz deleted the node-releases branch November 1, 2020 18:56
saschanaz added a commit to saschanaz/browser-compat-data that referenced this pull request Nov 1, 2020
saschanaz added a commit to saschanaz/browser-compat-data that referenced this pull request Nov 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:browsers 🌍 Data about browsers (versions, release dates, etc). This data is used for validation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants