Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WebAPI] Ship Web MIDI API #22111

Closed
9 tasks done
hamishwillee opened this issue Nov 7, 2022 · 4 comments
Closed
9 tasks done

[WebAPI] Ship Web MIDI API #22111

hamishwillee opened this issue Nov 7, 2022 · 4 comments
Assignees
Labels
Content:WebAPI Web API docs fx release archive A closed issue relating to firefox release notes for developers.

Comments

@hamishwillee
Copy link
Collaborator

hamishwillee commented Nov 7, 2022

Acceptance Criteria

  • The listed features are documented sufficiently on MDN
  • BCD is updated
  • Interactive example and data repos are updated if appropriate
  • The content has been reviewed as needed

For folks helping with Firefox related documentation

  • Set bugs to dev-doc-complete
  • Add entry to Firefox release notes if feature is enabled in release
  • Add entry to Firefox experimental features page if feature is not yet enabled in release

Features to document

Most of the work done for this already, most recently as items linked from #21951 - e.g. mdn/browser-compat-data#18160

We will need:

  • BCD
  • mark as FF108 release and delete the old notes.
  • Search on dom.webmidi.enabled as this is what is now default true except on Android
  • If FF site add on docs exist, then link them from the release.
  • Release note

There is nothing in experimental features.
Note, dom.webmidi.gated preference is on by default and will disappear from the docs following this change. That's OK IMO - it was only there as an intermediate step when it wasn't possible to get site permission add ons.

Related Gecko bugs

https://bugzilla.mozilla.org/show_bug.cgi?id=1795025

Other

  • Check content open issues to see if any pertain to the subject matter. If there are any that can be closed because of the work, do so. If there are any that can be fixed relatively quickly because of the knowledge from completing this issue and you have time, feel free to go ahead and fix them.
  • Check if BCD update means that content pages need to have experimental markup removed or deprecated markup added (front matter tags and macros).
@hamishwillee hamishwillee self-assigned this Nov 7, 2022
@github-actions github-actions bot added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Nov 7, 2022
@hamishwillee hamishwillee added Content:WebAPI Web API docs Firefox 108 and removed needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. labels Nov 7, 2022
@sethidden
Copy link

sethidden commented Nov 7, 2022

Sorry - do you know what happened to the Mozilla website describing site permission extensions https://extensionworkshop.com/documentation/publish/site-permission-add-on/ ?

It's still available on https://web.archive.org/web/20220315115841/https://extensionworkshop.com/documentation/publish/site-permission-add-on/

I'm kind of confused whether dom.webmidi.gated is now only a setting that does nothing and site permission extensions aren't necessary anymore? Or does the setting work as before - so that it requires the extension to be published?

I always though site permission extensions are actual extensions that need to be published on the Firefox addon store, but it looks like dom.webmidi.gated just shows the permission extension prompt on its own whenever a website asks for midi access? Without any action by a webmidi-enabled website's developer

@hamishwillee
Copy link
Collaborator Author

@sethidden The short version is that you should pretend that mechanism for getting an extension never existed and use a version of Firefox nightly greater than 107. Firefox will generate the addon - so as a developer you don't have to do anything. As a user you will have to acknowledge a prompt and install the plugin.

The new system allows more customized prompting than just using the permissions API and provides a consistent mechanism for a user to disable permissions (i.e. through the add ons config page).

The versions of FF around 100-104 are now unusable with this feature. From 105 you could set dom.webmidi.gated=false to disable the feature.

The compatibility data has been updated in source, but has not yet updated on the live site.

@hamishwillee
Copy link
Collaborator Author

hamishwillee commented Nov 8, 2022

Status:

@Rumyra
Copy link
Collaborator

Rumyra commented Nov 15, 2022

Closing as bcd should go through at some point 👍

@Rumyra Rumyra closed this as completed Nov 15, 2022
@Josh-Cena Josh-Cena added fx release archive A closed issue relating to firefox release notes for developers. and removed Firefox 108 labels Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebAPI Web API docs fx release archive A closed issue relating to firefox release notes for developers.
Projects
Archived in project
Development

No branches or pull requests

4 participants