Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FF108 Web MIDI API released #18213

Merged
merged 6 commits into from Nov 23, 2022
Merged

Conversation

hamishwillee
Copy link
Collaborator

FF108 ships web midi in https://bugzilla.mozilla.org/show_bug.cgi?id=1795025 . This adds the release version and adds a version_removed for the preferenced version.

Other docs work for this can be tracked in mdn/content#22111

FYI @queengooborg

@github-actions github-actions bot added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Nov 15, 2022
Copy link
Collaborator

@queengooborg queengooborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's just remove the flag data; Firefox 108 is coming out soon so we'll remove it soon anyways!

@hamishwillee
Copy link
Collaborator Author

@queengooborg Please see my comments on #18081 (comment)

@hamishwillee
Copy link
Collaborator Author

hamishwillee commented Nov 21, 2022

@queengooborg For this one we need to keep the preference data in until it is really released. We've tried to release this before and it is such a lot of data to revert if this gets pulled out yet again.

api/Navigator.json Outdated Show resolved Hide resolved
api/Navigator.json Outdated Show resolved Hide resolved
api/Navigator.json Outdated Show resolved Hide resolved
api/Navigator.json Outdated Show resolved Hide resolved
"firefox": [
{
"version_added": "108",
"notes": "API access is gated by installation of a <a href='https://support.mozilla.org/en-US/kb/site-permission-addons'>site permission add-on</a> (user prompt), secure context, and <a href='https://developer.mozilla.org/docs/Web/HTTP/Headers/Feature-Policy/midi'>Permission Policy: <code>midi</code></a>."
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, this merged in from changes in #18160 (now closed)

Copy link
Collaborator

@queengooborg queengooborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After the back-and-forth conversation in Slack, I'm just going to go ahead and merge this as-is and remove the flag data in a follow-up PR. LGTM!

Copy link
Collaborator

@queengooborg queengooborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, actually, looks like there's a consistency issue that must be fixed first!

api/Navigator.json Outdated Show resolved Hide resolved
hamishwillee and others added 2 commits November 23, 2022 08:54
Co-authored-by: Queen Vinyl Da.i'gyu-Kazotetsu <vinyldarkscratch@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants