Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement onscrollend event handler #22814

Closed
13 tasks done
Tracked by #281
Rumyra opened this issue Dec 8, 2022 · 6 comments
Closed
13 tasks done
Tracked by #281

Implement onscrollend event handler #22814

Rumyra opened this issue Dec 8, 2022 · 6 comments
Assignees
Labels
Content:WebAPI Web API docs fx release archive A closed issue relating to firefox release notes for developers.

Comments

@Rumyra
Copy link
Collaborator

Rumyra commented Dec 8, 2022

Acceptance Criteria

  • The listed features are documented sufficiently on MDN
  • BCD is updated
  • Interactive example and data repos are updated if appropriate
  • The content has been reviewed as needed

For folks helping with Firefox related documentation

  • Set bugs to dev-doc-complete
  • Add entry to Firefox release notes if feature is enabled in release
  • Add entry to Firefox experimental features page if feature is not yet enabled in release

Features to document

onscrollend

Related Gecko bugs

https://bugzilla.mozilla.org/show_bug.cgi?id=1797013
https://bugzilla.mozilla.org/show_bug.cgi?id=1803435

Other

  • Check content open issues to see if any pertain to the subject matter. If there are any that can be closed because of the work, do so. If there are any that can be fixed relatively quickly because of the knowledge from completing this issue and you have time, feel free to go ahead and fix them.
  • Check if glossary updates are required for the feature you're documenting - whether an existing term needs to be updated or a new term should be added.
  • Check if BCD update means that content pages need to have experimental markup removed or deprecated markup added (front matter tags and macros).

mdn/mdn#252

Related pull requests and issues

@github-actions github-actions bot added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Dec 8, 2022
@Rumyra Rumyra added Firefox 108 and removed needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. labels Dec 8, 2022
@bsmth bsmth self-assigned this Dec 8, 2022
@bsmth
Copy link
Member

bsmth commented Dec 8, 2022

Resources:

Related pull requests:

Bugzilla:

From the spec:

Event Interface Interesting targets Description
scrollend Event Document, elements Fired at the Document or element when scroll is completed: the viewport or element has been scrolled, the scroll sequence has ended and any scroll offset changes have been applied.

@dlrobertson
Copy link
Contributor

dlrobertson commented Dec 9, 2022

FWIW I just landed the change to enable scrollend events by default, see bug 1803435.

@bsmth
Copy link
Member

bsmth commented Dec 9, 2022

FWIW I just landed the change to enable scrollend events by default, see bug 1803435.

Thanks for the heads up, I've added a comment there to link back to the docs additions.

@bsmth
Copy link
Member

bsmth commented Jan 3, 2023

This is complete for 108 including nightly & experimental release notes.

For Fx 109 stable release, we need to move out the experimental note into the release notes.

@dlrobertson
Copy link
Contributor

This is complete for 108 including nightly & experimental release notes.

For Fx 109 stable release, we need to move out the experimental note into the release notes.

👍 just read the MDN doc and it looks great! Thanks!

@bsmth
Copy link
Member

bsmth commented Jan 11, 2023

Closing this one as done now ✅

@bsmth bsmth closed this as completed Jan 11, 2023
@Josh-Cena Josh-Cena added Content:WebAPI Web API docs fx release archive A closed issue relating to firefox release notes for developers. and removed Firefox 108 labels Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebAPI Web API docs fx release archive A closed issue relating to firefox release notes for developers.
Projects
Archived in project
Development

No branches or pull requests

4 participants