Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(API): cleanup element scrollend example #23380

Merged
merged 1 commit into from
Jan 4, 2023

Conversation

dlrobertson
Copy link
Contributor

Description

  • Move the scrollend example inline css into a separate hidden css section
  • Add a border box to the element to clarify where the borders of the scrollable element is.

Motivation

It isn't immediately clear where the scrollable element boundaries are. When I tested the element scrollend example I didn't know where the element was, so I initially attempted scrolls outside the scrollable element until I read the example implementation (something I probably should have done first 馃槂).

Related issues and pull requests

Related to: #22814

 - Move the scrollend example inline css into a separate hidden css
   section
 - Add a border box to the element to clarify where the borders of
   the scrollable element is.
@dlrobertson dlrobertson requested a review from a team as a code owner January 4, 2023 17:55
@dlrobertson dlrobertson requested review from wbamberg and removed request for a team January 4, 2023 17:55
@github-actions github-actions bot added the Content:WebAPI Web API docs label Jan 4, 2023
@dlrobertson
Copy link
Contributor Author

CC: @bsmth

Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@estelle estelle merged commit 632cd2a into mdn:main Jan 4, 2023
@dlrobertson dlrobertson deleted the element-scrollend-example branch January 4, 2023 23:18
@bsmth
Copy link
Member

bsmth commented Jan 5, 2023

Thanks @dlrobertson 馃檶馃徎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebAPI Web API docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants