New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update encodeURIComponent() parameter information #10123
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyotijangid
requested review from
sideshowbarker
and removed request for
a team
October 27, 2021 17:18
Preview URLsFlawsNone! 🎉 External URLsURL: No new external URLs (this comment was updated 2021-10-30 02:15:01.573959) |
jyotijangid
changed the title
Issue 10093
Parameter changed to Oct 27, 2021
uriComponent
which can be string, number, Boolean, other objects
jyotijangid
changed the title
Parameter changed to
Parameter changed to Oct 27, 2021
uriComponent
which can be string, number, Boolean, other objectsuriComponent
which can be string, number, boolean, other objects
files/en-us/web/javascript/reference/global_objects/encodeuricomponent/index.md
Outdated
Show resolved
Hide resolved
…omponent/index.md
files/en-us/web/javascript/reference/global_objects/encodeuricomponent/index.md
Outdated
Show resolved
Hide resolved
…omponent/index.md
files/en-us/web/javascript/reference/global_objects/encodeuricomponent/index.md
Outdated
Show resolved
Hide resolved
…omponent/index.md
sideshowbarker
approved these changes
Oct 30, 2021
sideshowbarker
changed the title
Parameter changed to
Update encodeURIComponent() parameter information
Oct 30, 2021
uriComponent
which can be string, number, boolean, other objects
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Parameter changed to
uriComponent
which can be astring
,number
,boolean
,null
,undefined
or any other object.Motivation
Before encoding
uriComponent
is typecasted to string, using toString method.Supporting details
Ref - https://tc39.es/ecma262/multipage/global-object.html#sec-encodeuricomponent-uricomponent
Similar issue was raised in TypeScript - microsoft/TypeScript#18159
Related issues
Fixes #10093
Metadata