19449 prefers color scheme #20886
Merged
19449 prefers color scheme #20886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
|
Preview URLs (this comment was updated 2022-10-13 08:06:12.550723) |
|
I'm away until Monday. @estelle would perhaps be a better person to review CSS. |
caugner
reviewed
Sep 21, 2022
estelle
reviewed
Oct 6, 2022
estelle
reviewed
Oct 6, 2022
estelle
reviewed
Oct 6, 2022
Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>
Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>
estelle
reviewed
Oct 13, 2022
estelle
reviewed
Oct 13, 2022
estelle
reviewed
Oct 13, 2022
estelle
reviewed
Oct 13, 2022
estelle
reviewed
Oct 13, 2022
estelle
reviewed
Oct 13, 2022
Thank you, incorporating the comments now. |
Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>
estelle
reviewed
Oct 13, 2022
estelle
approved these changes
Oct 13, 2022
|
Thanks, Estelle 🙌🏻 |
mfuji09
pushed a commit
to mfuji09/MDN-content
that referenced
this pull request
Oct 20, 2022
* docs(CSS): prefers-color-scheme for embedded content * docs(CSS): minor fix for coloer-scheme * chore(build) replace Prettier config * docs(CSS): add example of embedded SVG for prefers-color-scheme * docs(CSS): add xrefs for color-scheme & prefers-color-scheme * docs(CSS): improve wording for prefers-color-scheme docs * typo fix * docs(CSS) add details on secure animated mode for SVGs * Update files/en-us/web/css/@media/prefers-color-scheme/index.md Co-authored-by: Estelle Weyl <estelle@openwebdocs.org> * Update files/en-us/web/css/@media/prefers-color-scheme/index.md Co-authored-by: Estelle Weyl <estelle@openwebdocs.org> * chore(docs) Clarify embedded SVG details, links to supporting docs * Apply suggestions from code review Co-authored-by: Estelle Weyl <estelle@openwebdocs.org> * docs(CSS): Link to more appropriate inline SVG example, minor copy fix * grammar Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background:
Embedded SVGs and iframes can now use
prefers-color-schememedia query to add styles that inherit (depend on) thecolor-schemeof the embedding element.This PR adds details about embedded elements and how media queries can be used to control how embedded elements are styled based on embedding elements. There's an additional example that shows default functionality (browser or OS prefs) and then explicit styling based on the parent (embedding) element.
Other issues and PRs:
prefers-color-schemereflects thecolor-schemeon the embedding element #19449