Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sqrt() - New CSS functional notation #21154

Merged
merged 6 commits into from Oct 6, 2022
Merged

sqrt() - New CSS functional notation #21154

merged 6 commits into from Oct 6, 2022

Conversation

ramiy
Copy link
Contributor

@ramiy ramiy commented Sep 28, 2022

Description

Document the CSS sqrt() functional notation.

Motivation

I'm documenting all the exponential CSS functions.

Additional details

https://www.w3.org/TR/css-values-4/#exponent-funcs

Related issues and pull requests

@ramiy ramiy requested a review from a team as a code owner September 28, 2022 13:41
@ramiy ramiy requested review from dipikabh and removed request for a team September 28, 2022 13:41
@github-actions github-actions bot added the Content:CSS Cascading Style Sheets docs label Sep 28, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 28, 2022

Preview URLs

Flaws (1)

URL: /en-US/docs/Web/CSS/sqrt
Title: sqrt()
Flaw count: 1

  • macros:
    • /en-US/docs/Web/CSS/hypot does not exist
External URLs (1)

URL: /en-US/docs/Web/CSS/sqrt
Title: sqrt()

(this comment was updated 2022-10-05 23:16:04.395393)

Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ramiy!

Looks good to me, just one comment.

Also, we're defining a new page-type front matter key in the CSS docs - I've made a suggestion here to add it for this page, but for future reference in case you add more of these pages :). There will be docs for it in the next day or so.

files/en-us/web/css/sqrt/index.md Show resolved Hide resolved
files/en-us/web/css/sqrt/index.md Outdated Show resolved Hide resolved
ramiy and others added 2 commits September 30, 2022 15:23
Co-authored-by: wbamberg <will@bootbonnet.ca>
@ramiy ramiy requested review from wbamberg and removed request for dipikabh October 2, 2022 10:37
Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thank you @ramiy !

@wbamberg wbamberg merged commit 16996a7 into mdn:main Oct 6, 2022
@ramiy ramiy deleted the patch-3 branch October 6, 2022 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:CSS Cascading Style Sheets docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants