Add new screen capture constraints and options #22733

chrisdavidmills · 2022-12-05T06:47:03Z

Description

This PR adds a bunch of content covering new constraints and options from the screen capture API. You can see what's been added in my research document, at https://docs.google.com/document/d/1HUZMVu_hGTUdkThLhqrUDMBKqvFS5YNRs0xGEHIYaMY/edit#heading=h.frl8u3cowbcx

Motivation

Additional details

Related issues and pull requests

github-actions · 2022-12-05T06:49:41Z

Preview URLs (12 pages)

Flaws (12)

Note! 3 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/Screen_Capture_API
Title: Screen Capture API
Flaw count: 3

macros:
- /en-US/docs/Web/API/MediaTrackConstraints/cursor redirects to /en-US/docs/Web/API/MediaTrackConstraints
- /en-US/docs/Web/API/MediaTrackSupportedConstraints/cursor redirects to /en-US/docs/Web/API/MediaTrackSupportedConstraints
- /en-US/docs/Web/API/MediaTrackConstraints/cursor redirects to /en-US/docs/Web/API/MediaTrackConstraints

URL: /en-US/docs/Web/API/Screen_Capture_API/Using_Screen_Capture
Title: Using the Screen Capture API
Flaw count: 2

macros:
- The fourth to sixth parameters of 'EmbedLiveSample' are deprecated
broken_links:
- Can't resolve /en-US/docs/Web/API/WebRTC_API/Taking_still_photos

URL: /en-US/docs/Web/API/MediaTrackConstraints
Title: MediaTrackConstraints
Flaw count: 1

bad_bcd_links:
- no explanation!

URL: /en-US/docs/Web/API/MediaTrackConstraints/suppressLocalAudioPlayback
Title: MediaTrackConstraints.suppressLocalAudioPlayback
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: api.MediaTrackConstraints.suppressLocalAudioPlayback

URL: /en-US/docs/Web/API/MediaTrackSupportedConstraints/suppressLocalAudioPlayback
Title: MediaTrackSupportedConstraints.suppressLocalAudioPlayback
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: api.MediaTrackSupportedConstraints.suppressLocalAudioPlayback

URL: /en-US/docs/Web/API/CaptureController
Title: CaptureController
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: api.CaptureController

URL: /en-US/docs/Web/API/CaptureController/setFocusBehavior
Title: CaptureController.setFocusBehavior()
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: api.CaptureController.setFocusBehavior

URL: /en-US/docs/Web/API/CaptureController/CaptureController
Title: CaptureController()
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: api.CaptureController.setFocusBehavior

URL: /en-US/docs/Web/API/MediaTrackSettings/suppressLocalAudioPlayback
Title: MediaTrackSettings.suppressLocalAudioPlayback
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: api.MediaTrackSettings.suppressLocalAudioPlayback

External URLs (3)

URL: /en-US/docs/Web/API/CaptureController
Title: CaptureController

https://developer.chrome.com/docs/web-platform/conditional-focus/ (1 time) (Note! This may be a new URL 👀)

URL: /en-US/docs/Web/API/CaptureController/setFocusBehavior
Title: CaptureController.setFocusBehavior()

https://developer.chrome.com/docs/web-platform/conditional-focus/ (1 time) (Note! This may be a new URL 👀)

URL: /en-US/docs/Web/API/CaptureController/CaptureController
Title: CaptureController()

https://developer.chrome.com/docs/web-platform/conditional-focus/ (1 time) (Note! This may be a new URL 👀)

(comment last updated: 2022-12-19 11:00:20)

dipikabh · 2022-12-06T23:48:11Z

Hi @wbamberg, hope it is okay to leave the review for this PR to you

beaufortfrancois

Thank you @chrisdavidmills!

beaufortfrancois · 2022-12-07T09:38:02Z

files/en-us/web/api/capturecontroller/setfocusbehavior/index.md

+### Exceptions
+
+- `InvalidStateError` {{domxref("DOMException")}}
+  - : Thrown if the capture stream has been stopped, or if enough time has elapsed after the {{domxref("MediaDevices.getDisplayMedia()")}} `Promise` fulfills that the focus behavior has been finalized.


Calling setFocusBehavior() also throws after the getDisplayMedia() returned promise resolves, if the user shared a screen (not a tab or a window).

OK, updating this in my next commit. Since the number of different circumstances for throwing an InvalidState error got to three, I've split them out into a bulleted list to make them easier to read.

beaufortfrancois · 2022-12-07T09:41:35Z

files/en-us/web/api/mediatrackconstraints/displaysurface/index.md

@@ -54,14 +54,14 @@ to this:
 let mayHaveBackdropFlag = false;
 let displaySurface = displayStream.getVideoTracks()[0].getSettings().displaySurface;

-if (displaySurface === "monitor" || displaySurface ==="application") {
+if (displaySurface === "monitor" || displaySurface ==="window") {


I'm not sure we want to replace "application" with "window" there. If so, you may want to update the paragraph above that still uses "application" then.

Ah, good spot; I missed that mention of "application". I've updated it to "window" to match the code snippet, as the "application" value was removed from the spec. I'm not sure if it has been removed from browsers yet, but I thought this would be good defensive writing for either eventuality.

beaufortfrancois · 2022-12-07T09:44:18Z

files/en-us/web/api/mediatrackconstraints/suppresslocalaudioplayback/index.md

+attempt to obtain media with local audio playback enabled or disabled as specified, if
+possible, but will not fail if this can't be done. If, instead, the value is given as an
+object with an `exact` field, that field's Boolean value indicates a required
+setting for the noise suppression feature; if it can't be met, then the request will


Exact values are not allowed in getDisplayMedia calls. They are in applyConstraints calls.

I've had a go at updating this section, but I do find these constraint object values rather confusing. You'll have to let me know if you think I'm any closer to getting it right. This also makes me think of two other issues:

We ought to look at the other screen capture-specific constraints, and see if they are correct in terms of not using exact.

I ought to put the note about exact not being permitted in getDisplayMedia calls somewhere in the main http://localhost:5042/en-US/docs/Web/API/MediaTrackConstraints page, so it is more visible. But probably not on every individual constraint page.
What do you think?

Maybe the getDisplayMedia page as well? See https://w3c.github.io/mediacapture-screen-share/#dfn-floor-value:~:text=While%20min%20and%20exact%20constraints%20produce%20TypeError

Good call. I've checked, and it is kind of covered on the getDisplayMedia() page, in the TypeError entry in the Exceptions section, but I've added in a line explicitly to say that min and exact are not allowed.

I've also followed my plan as outlined above.

beaufortfrancois · 2022-12-07T09:46:36Z

files/en-us/web/api/mediatracksettings/suppresslocalaudioplayback/index.md

+async function capture() {
+  let supportedConstraints = navigator.mediaDevices.getSupportedConstraints();
+  let displayMediaOptions = {
+    video: {},


This line is not needed as default value for video is true.

OK, removed.

beaufortfrancois · 2022-12-07T09:46:52Z

files/en-us/web/api/mediatracksettings/suppresslocalaudioplayback/index.md

+
+```js
+async function capture() {
+  let supportedConstraints = navigator.mediaDevices.getSupportedConstraints();


Nit: Use const instead of let.

Agreed; changed.

beaufortfrancois · 2022-12-07T09:47:21Z

files/en-us/web/api/mediatracksupportedconstraints/suppresslocalaudioplayback/index.md

+async function capture() {
+  let supportedConstraints = navigator.mediaDevices.getSupportedConstraints();
+  let displayMediaOptions = {
+    video: {},


beaufortfrancois · 2022-12-07T09:47:31Z

files/en-us/web/api/mediatracksupportedconstraints/suppresslocalaudioplayback/index.md

+
+```js
+async function capture() {
+  let supportedConstraints = navigator.mediaDevices.getSupportedConstraints();


beaufortfrancois · 2022-12-07T09:50:07Z

files/en-us/web/api/screen_capture_api/using_screen_capture/index.md

-  }
+  },
+  surfaceSwitching: true,
+  selfBrowserSurface: false


It should be either "include" or "exclude" for both surfaceSwitching and selfBrowserSurface

You could also suppressLocalAudioPlayback in audio, video: { displaySurface: "window" }, and systemAudio: "exclude" as well

Good call, it's nice to have those constraints/options shown. I've added them.

chrisdavidmills · 2022-12-07T11:05:08Z

@beaufortfrancois OK, fixes pushed; thanks for all the comments! There are a couple that I think require a bit more input from you, but overall this is getting close.

beaufortfrancois · 2022-12-07T11:38:51Z

files/en-us/web/api/mediatrackconstraints/displaysurface/index.md

@@ -47,7 +47,7 @@ video {{domxref("MediaStreamTrack")}}, then checking the value of the returned
 {{domxref("MediaTrackSettings.displaySurface", "displaySurface")}} object.

 For example, if your app needs to know that the surface being shared is a monitor or
-application—meaning that there's possibly a non-content backdrop—it can use code similar
+window—meaning that there's possibly a non-content backdrop—it can use code similar


I'm not sure which non-content backdrop appears in a single window?

Good point; I've changed it so that it only applies to a fullscreen/monitor capture.

beaufortfrancois · 2022-12-07T11:40:30Z

files/en-us/web/api/screen_capture_api/using_screen_capture/index.md

-  selfBrowserSurface: false
+  surfaceSwitching: "include",
+  selfBrowserSurface: "exclude",
+  systemAudio: "exclude"


You may want to update the explanation text as well then.

Good point; explanation updated.

beaufortfrancois · 2022-12-07T11:43:50Z

files/en-us/web/api/mediatrackconstraints/suppresslocalaudioplayback/index.md

+attempt to obtain media with local audio playback enabled or disabled as specified, if
+possible, but will not fail if this can't be done. If, instead, the value is given as an
+object with an `exact` field, that field's Boolean value indicates a required
+setting for the noise suppression feature; if it can't be met, then the request will


Maybe the getDisplayMedia page as well? See https://w3c.github.io/mediacapture-screen-share/#dfn-floor-value:~:text=While%20min%20and%20exact%20constraints%20produce%20TypeError

chrisdavidmills · 2022-12-07T12:44:20Z

@beaufortfrancois OK, more fixes made. Thanks again!

beaufortfrancois · 2022-12-07T12:47:02Z

LGTM! Thank you!

wbamberg · 2022-12-15T00:02:09Z

Related BCD PR -> mdn/browser-compat-data#18264.

wbamberg

Sorry for the delay, Chris!

wbamberg · 2022-12-14T22:51:23Z

files/jsondata/GroupData.json

-        "MediaTrackSupportedConstraints.displaySurface",
-        "MediaTrackSupportedConstraints.logicalSurface"
+        "MediaTrackSettings.suppressLocalAudioPlayback",
+        "MediaTrackSupportedConstraints"


"MediaTrackSupportedConstraints" isn't a property so this can't be right. Looking at the spec there seem to be three dictionaries that are relevant (i.e. that are defined as partials and that are documented as standalone entities on MDN):

MediaTrackSupportedConstraints MediaTrackConstraintSet (although this is documented in the subclass MediaTrackConstraints) MediaTrackSettings

These all have properties with the same names:

displaySurface logicalSurface cursor restrictOwnAudio suppressLocalAudioPlayback

So I guess I would expect to see 15 entries here, 5 for each of those dictionaries?

I was kinda trying to reduce the amount of verbiage in the sidebar, as I felt it looked a bit horrible ;-)

But I appreciate that what I did doesn't really work.

I have added the separate MediaTrackSupportedConstraints.* pages back in, in my next commit.

Some notes:

I've not included *.restrictOwnAudio pages, as restrictOwnAudio is not part of this PR; I don't think it is supported yet.

I've removed MediaTrackSupportedConstraints.cursor and MediaTrackConstraints.cursor; those URLs redirect to the parent class page, as they don't exist any more. I'm not really sure why.

wbamberg · 2022-12-14T23:46:02Z

files/en-us/web/api/screen_capture_api/index.md

 - {{domxref("MediaTrackConstraints.logicalSurface")}}
  - : Indicates whether or not the video in the stream represents a logical display surface (that is, one which may not be entirely visible onscreen, or may be completely offscreen). A value of `true` indicates a logical display surface is to be captured.
+- {{domxref("MediaTrackConstraints.suppressLocalAudioPlayback")}}


This and the other dictionaries omits restrictOwnAudio, is there a reason for that?

See above; not part of this PR, I don't think it is supported yet

wbamberg · 2022-12-15T00:05:15Z

files/en-us/web/api/capturecontroller/setfocusbehavior/index.md

+
+### Return value
+
+`Undefined`.


Suggested change

`Undefined`.

None (`undefined`).

Change made in next commit.

wbamberg · 2022-12-15T00:06:04Z

files/en-us/web/api/mediadevices/getdisplaymedia/index.md

@@ -35,28 +33,37 @@ See [Using the Screen Capture API](/en-US/docs/Web/API/Screen_Capture_API/Using_
 ## Syntax

 ```js-nolint
-getDisplayMedia(constraints)
+getDisplayMedia(options)


Suggested change

getDisplayMedia(options)

getDisplayMedia()

getDisplayMedia(options)

I guess, since this is optional?

Makes sense; added in next commit

wbamberg · 2022-12-15T00:07:05Z

files/en-us/web/api/mediadevices/getdisplaymedia/index.md

+- `options` {{optional_inline}}
+  - : An optional object specifying requirements for the returned {{domxref("MediaStream")}}. The options for `getDisplayMedia()` work in the same as the [constraints](/en-US/docs/Web/API/MediaDevices/getUserMedia#parameters) for the {{domxref("MediaDevices.getUserMedia()")}} method, although in that case only `audio` and `video` can be specified. The list of possible option properties for `getDisplayMedia()` is as follows:


This <dl> is broken, probably because of the indentation. (it's a bit of a shame that our <dl> is quite fragile).

I tried to fix this for ages when I was originally writing this, and gave up ;-)

I just had another look, and realized that it was because the note following the <dl> was indented. Fixed in next commit.

wbamberg · 2022-12-15T00:50:21Z

files/en-us/web/api/mediatracksettings/suppresslocalaudioplayback/index.md

+  }
+
+  try {
+    videoElem.srcObject = await navigator.mediaDevices.getDisplayMedia(displayMediaOptions);


Not sure what I'm missing here. We're passing an options object into getDisplayMedia. The object has an audio property which is itself an object, with a boolean suppressLocalAudioPlayback property. But in the page for getDisplayMedia it says that audio is a boolean, not an object.

It can also be a MediaTrackConstraints object.

wbamberg · 2022-12-15T00:50:51Z

files/en-us/web/api/mediatracksupportedconstraints/suppresslocalaudioplayback/index.md

+
+## Value
+
+A Boolean value which is `true` if the {{domxref("MediaTrackConstraints.suppressLocalAudioPlayback", "suppressLocalAudioPlayback")}} constraint is supported by the device and user agent.


Suggested change

A Boolean value which is `true` if the {{domxref("MediaTrackConstraints.suppressLocalAudioPlayback", "suppressLocalAudioPlayback")}} constraint is supported by the device and user agent.

A boolean value which is `true` if the {{domxref("MediaTrackConstraints.suppressLocalAudioPlayback", "suppressLocalAudioPlayback")}} constraint is supported by the device and user agent.

wbamberg · 2022-12-15T01:56:18Z

files/en-us/web/api/mediatracksupportedconstraints/suppresslocalaudioplayback/index.md

+
+## Examples
+
+The below function sets up the constraints object specifying the options for the call to {{domxref("MediaDevices.getDisplayMedia", "getDisplayMedia()")}}. It adds the `suppressLocalAudioPlayback` constraint (requesting that captured audio is not played out of the user's local speakers) only if it is known to be supported by the browser. Capturing is then started by calling `getDisplayMedia()` and attaching the returned stream to the video element referenced by the variable `videoElem`.


Suggested change

The below function sets up the constraints object specifying the options for the call to {{domxref("MediaDevices.getDisplayMedia", "getDisplayMedia()")}}. It adds the `suppressLocalAudioPlayback` constraint (requesting that captured audio is not played out of the user's local speakers) only if it is known to be supported by the browser. Capturing is then started by calling `getDisplayMedia()` and attaching the returned stream to the video element referenced by the variable `videoElem`.

The function below sets up the options object for the call to {{domxref("MediaDevices.getDisplayMedia", "getDisplayMedia()")}}. It adds the `suppressLocalAudioPlayback` constraint (requesting that captured audio is not played out of the user's local speakers) only if it is known to be supported by the browser. Capturing is then started by calling `getDisplayMedia()` and attaching the returned stream to the video element referenced by the variable `videoElem`.

update made

wbamberg · 2022-12-15T02:18:51Z

files/en-us/web/api/screen_capture_api/using_screen_capture/index.md


-> **Note:** Unlike most uses of constraints in media APIs, here it's solely used to define the stream configuration, and _not_ to filter the available choices.
+The `video` and `audio` objects pased in to the options object can also hold additional constraints particular to those media tracks. See [Properties of shared screen tracks](/en-US/docs/Web/API/MediaTrackConstraints#properties_of_shared_screen_tracks) for details about additional constraints for configuring a screen-capture stream that are added to {{domxref("MediaTrackConstraints")}}, {{domxref("MediaTrackSupportedConstraints")}}, and {{domxref("MediaTrackSettings")}}).


Suggested change

The `video` and `audio` objects pased in to the options object can also hold additional constraints particular to those media tracks. See [Properties of shared screen tracks](/en-US/docs/Web/API/MediaTrackConstraints#properties_of_shared_screen_tracks) for details about additional constraints for configuring a screen-capture stream that are added to {{domxref("MediaTrackConstraints")}}, {{domxref("MediaTrackSupportedConstraints")}}, and {{domxref("MediaTrackSettings")}}).

The `video` and `audio` objects passed into the options object can also hold additional constraints particular to those media tracks. See [Properties of shared screen tracks](/en-US/docs/Web/API/MediaTrackConstraints#instance_properties_of_shared_screen_tracks) for details about additional constraints for configuring a screen-capture stream that are added to {{domxref("MediaTrackConstraints")}}, {{domxref("MediaTrackSupportedConstraints")}}, and {{domxref("MediaTrackSettings")}}).

wbamberg · 2022-12-15T03:23:27Z

files/en-us/web/api/screen_capture_api/using_screen_capture/index.md

@@ -159,7 +166,7 @@ There isn't all that much code needed in order to make this work, and if you're

 First, some constants are set up to reference the elements on the page to which we'll need access: the {{HTMLElement("video")}} into which the captured screen contents will be streamed, a box into which logged output will be drawn, and the start and stop buttons that will turn on and off capture of screen imagery.

-The object `displayMediaOptions` contains the constraints to pass into `getDisplayMedia()`; here, the {{domxref("MediaTrackConstraints.cursor", "cursor")}} property is set to `always`, indicating that the mouse cursor should always be included in the captured media.
+The object `displayMediaOptions` contains the options to pass into `getDisplayMedia()`; here, the {{domxref("MediaTrackConstraints.cursor", "cursor")}} property is set to `always`, indicating that the mouse cursor should always be included in the captured media.

 > **Note:** Some properties are not widely implemented and might not be used by the engine. `cursor`, for example, [has limited support](/en-US/docs/Web/API/MediaTrackConstraints#browser_compatibility).


cursor doesn't appear in the linked table. (In general I don't really like notes like this. People always need to check the compat tables.)

This is a bad example, it looks like cursor has been removed, as a number of the cursor-related pages no longer exist. I've changed it to use displaySurface.

Question - the live sample should update automatically, right? I've completely forgotten how they work ;-)

Yes, live samples just work.

chrisdavidmills · 2022-12-19T10:56:44Z

Thanks for the review @wbamberg ! I think I've addressed everything

wbamberg

👍 thank you for the updates, Chris!

chrisdavidmills · 2022-12-19T19:31:04Z

Woo hoo! Thanks @wbamberg!

Add new screen capture constraints and options

7c129ee

chrisdavidmills requested review from a team as code owners December 5, 2022 06:47

chrisdavidmills requested review from wbamberg and dipikabh and removed request for a team December 5, 2022 06:47

github-actions bot added the Content:WebAPI Web API docs label Dec 5, 2022

beaufortfrancois reviewed Dec 7, 2022

View reviewed changes

Making fixes for beaufortfrancois comments

79fb868

beaufortfrancois reviewed Dec 7, 2022

View reviewed changes

Making fixes for beaufortfrancois comments

41f5a55

dipikabh removed their request for review December 12, 2022 16:06

wbamberg requested changes Dec 15, 2022

View reviewed changes

Making fixes for wbamberg comments

cb5fef8

Merge branch 'main' into add-screencapture-constraints-options

1d9639c

wbamberg approved these changes Dec 19, 2022

View reviewed changes

wbamberg merged commit 83eccbf into mdn:main Dec 19, 2022

chrisdavidmills deleted the add-screencapture-constraints-options branch December 19, 2022 19:30

	getDisplayMedia(options)
	getDisplayMedia()
	getDisplayMedia(options)

		- `options` {{optional_inline}}
		- : An optional object specifying requirements for the returned {{domxref("MediaStream")}}. The options for `getDisplayMedia()` work in the same as the [constraints](/en-US/docs/Web/API/MediaDevices/getUserMedia#parameters) for the {{domxref("MediaDevices.getUserMedia()")}} method, although in that case only `audio` and `video` can be specified. The list of possible option properties for `getDisplayMedia()` is as follows:


		## Value

		A Boolean value which is `true` if the {{domxref("MediaTrackConstraints.suppressLocalAudioPlayback", "suppressLocalAudioPlayback")}} constraint is supported by the device and user agent.


		## Examples

		The below function sets up the constraints object specifying the options for the call to {{domxref("MediaDevices.getDisplayMedia", "getDisplayMedia()")}}. It adds the `suppressLocalAudioPlayback` constraint (requesting that captured audio is not played out of the user's local speakers) only if it is known to be supported by the browser. Capturing is then started by calling `getDisplayMedia()` and attaching the returned stream to the video element referenced by the variable `videoElem`.


		> Note: Unlike most uses of constraints in media APIs, here it's solely used to define the stream configuration, and _not_ to filter the available choices.
		The `video` and `audio` objects pased in to the options object can also hold additional constraints particular to those media tracks. See [Properties of shared screen tracks](/en-US/docs/Web/API/MediaTrackConstraints#properties_of_shared_screen_tracks) for details about additional constraints for configuring a screen-capture stream that are added to {{domxref("MediaTrackConstraints")}}, {{domxref("MediaTrackSupportedConstraints")}}, and {{domxref("MediaTrackSettings")}}).

Add new screen capture constraints and options #22733

Add new screen capture constraints and options #22733

Conversation

chrisdavidmills commented Dec 5, 2022

Description

Motivation

Additional details

Related issues and pull requests

github-actions bot commented Dec 5, 2022 • edited

dipikabh commented Dec 6, 2022

beaufortfrancois left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chrisdavidmills Dec 7, 2022 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chrisdavidmills commented Dec 7, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chrisdavidmills commented Dec 7, 2022

beaufortfrancois commented Dec 7, 2022

wbamberg commented Dec 15, 2022

wbamberg left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chrisdavidmills commented Dec 19, 2022

wbamberg left a comment

Choose a reason for hiding this comment

chrisdavidmills commented Dec 19, 2022

github-actions bot commented Dec 5, 2022 •

edited

chrisdavidmills Dec 7, 2022 •

edited