Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite history API guide; delete old example #30354

Merged
merged 5 commits into from
Nov 20, 2023
Merged

Conversation

wbamberg
Copy link
Collaborator

Part of #30131.

mdn/dom-examples#236 added a new demo of the History API to dom-examples, to replace the one at https://developer.mozilla.org/en-US/docs/Web/API/History_API/Example which isn't really usable.

This PR deletes the old example page, and also rewrites the guide page at https://developer.mozilla.org/en-US/docs/Web/API/History_API/Working_with_the_History_API to be built around the new example, as I found the previous page not very helpful or easy to understand.

I hope I've not removed important stuff! As usual I don't know this very well so happy with any kind of feedback.

As a drive-by I also updated https://developer.mozilla.org/en-US/docs/Web/API/History/replaceState to fix an error (the corresponding change for pushState() was #30169).

@wbamberg wbamberg requested review from a team as code owners November 17, 2023 20:07
@wbamberg wbamberg requested review from sideshowbarker and removed request for a team November 17, 2023 20:07
@github-actions github-actions bot added Content:WebAPI Web API docs Content:Guide Guide docs labels Nov 17, 2023
@wbamberg wbamberg marked this pull request as draft November 18, 2023 02:38
@wbamberg wbamberg marked this pull request as ready for review November 18, 2023 02:45
@teoli2003 teoli2003 requested review from teoli2003 and removed request for a team and sideshowbarker November 18, 2023 09:51
Copy link
Member

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nit.

Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>
Copy link
Member

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving.

…ndex.md

Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>
@teoli2003 teoli2003 merged commit 56bbf28 into mdn:main Nov 20, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Guide Guide docs Content:WebAPI Web API docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants