Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial review: CSS anchor positioning 3: sizing and positioning part 1 #33493

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Editorial review: CSS anchor positioning 3: sizing and positioning part 1 #33493

wants to merge 8 commits into from

Conversation

chrisdavidmills
Copy link
Contributor

@chrisdavidmills chrisdavidmills commented May 8, 2024 •
edited

Description

CSS Anchor Positioning is set to be released in Chrome 125 (see the associated Chrome Status entry).

This PR (part of a series; see the first PR here) adds the following content:

  • The anchor() function
  • Properties that support anchor() as a value:
    • top
    • left
    • bottom
    • right
    • inset-block-start
    • inset-block-end
    • inset-inline-start
    • inset-inline-end
    • inset-block
    • inset-inline
    • inset
  • The anchor-center value, which is supported on the following properties:
    • justify-self
    • align-self
    • justify-items
    • align-items
    • place-items
    • place-self

Do not merge until #33058 is merged.

Motivation

Additional details

Related issues and pull requests

@chrisdavidmills chrisdavidmills requested a review from a team as a code owner May 8, 2024 14:31
@chrisdavidmills chrisdavidmills requested review from bsmth and removed request for a team May 8, 2024 14:31
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs size/m 51-500 LoC changed labels May 8, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 8, 2024 •
edited

Preview URLs (18 pages)
Flaws (23)

Note! 1 document with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/CSS/inset-block
Title: inset-block
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/CSS_anchor_positioning

URL: /en-US/docs/Web/CSS/anchor
Title: anchor()
Flaw count: 7

  • macros:
    • /en-US/docs/Web/CSS/anchor-name does not exist
    • /en-US/docs/Web/CSS/position-anchor does not exist
    • /en-US/docs/Web/CSS/anchor-name does not exist
  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/CSS_anchor_positioning
    • Can't resolve /en-US/docs/Web/HTML/Global_attributes/anchor
    • Can't resolve /en-US/docs/Web/CSS/CSS_anchor_positioning
    • Can't resolve /en-US/docs/Web/CSS/CSS_anchor_positioning/Using

URL: /en-US/docs/Web/CSS/right
Title: right
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/CSS_anchor_positioning

URL: /en-US/docs/Web/CSS/inset-inline
Title: inset-inline
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/CSS_anchor_positioning

URL: /en-US/docs/Web/CSS/inset-block-start
Title: inset-block-start
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/CSS_anchor_positioning

URL: /en-US/docs/Web/CSS/inset-inline-start
Title: inset-inline-start
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/CSS_anchor_positioning

URL: /en-US/docs/Web/CSS/justify-self
Title: justify-self
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/CSS_anchor_positioning

URL: /en-US/docs/Web/CSS/left
Title: left
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/CSS_anchor_positioning

URL: /en-US/docs/Web/CSS/bottom
Title: bottom
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/CSS_anchor_positioning

URL: /en-US/docs/Web/CSS/align-self
Title: align-self
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/CSS_anchor_positioning

URL: /en-US/docs/Web/CSS/place-self
Title: place-self
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/CSS_anchor_positioning

URL: /en-US/docs/Web/CSS/top
Title: top
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/CSS_anchor_positioning

URL: /en-US/docs/Web/CSS/inset-inline-end
Title: inset-inline-end
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/CSS_anchor_positioning

URL: /en-US/docs/Web/CSS/inset
Title: inset
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/CSS_anchor_positioning

URL: /en-US/docs/Web/CSS/inset-block-end
Title: inset-block-end
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/CSS_anchor_positioning

URL: /en-US/docs/Web/CSS/justify-items
Title: justify-items
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/CSS_anchor_positioning

URL: /en-US/docs/Web/CSS/align-items
Title: align-items
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/CSS_anchor_positioning

(comment last updated: 2024-05-25 12:22:23)

@chrisdavidmills chrisdavidmills changed the title Add anchor() function ref page Tech review: CSS anchor positioning 3: sizing and positioning May 8, 2024
@chrisdavidmills chrisdavidmills marked this pull request as draft May 8, 2024 14:46
@chrisdavidmills chrisdavidmills mentioned this pull request May 8, 2024
Open
@chrisdavidmills chrisdavidmills changed the title Tech review: CSS anchor positioning 3: sizing and positioning Tech review: CSS anchor positioning 3: sizing and positioning part 1 May 9, 2024
@chrisdavidmills chrisdavidmills marked this pull request as ready for review May 9, 2024 10:47
mfreed7
mfreed7 reviewed May 10, 2024
View reviewed changes
Copy link

@mfreed7 mfreed7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Lots of comments, but overall very nice.

files/en-us/web/css/align-items/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/align-self/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/anchor/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/anchor/index.md Show resolved Hide resolved
files/en-us/web/css/inset-block/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/inset-inline/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/left/index.md Show resolved Hide resolved
@bsmth bsmth removed their request for review May 13, 2024 11:58
@chrisdavidmills chrisdavidmills changed the title Tech review: CSS anchor positioning 3: sizing and positioning part 1 Editorial review: CSS anchor positioning 3: sizing and positioning part 1 May 20, 2024
@chrisdavidmills chrisdavidmills requested review from estelle and removed request for mfreed7 May 20, 2024 18:01
@chrisdavidmills
Copy link
Contributor Author

Thanks for the tech review, @mfreed7.

@estelle, this one is ready for editorial review too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfreed7 mfreed7 mfreed7 left review comments

@estelle estelle Awaiting requested review from estelle

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Content:CSS Cascading Style Sheets docs size/m 51-500 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chrisdavidmills @mfreed7