Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a glossary page on digital signatures #33507

Merged
merged 2 commits into from May 22, 2024

Conversation

wbamberg
Copy link
Collaborator

@wbamberg wbamberg commented May 8, 2024

The page on authentication is coming in #33360.

@wbamberg wbamberg requested a review from a team as a code owner May 8, 2024 23:00
@wbamberg wbamberg requested review from hamishwillee and removed request for a team May 8, 2024 23:00
@github-actions github-actions bot added Content:Glossary Glossary entries size/s 6-50 LoC changed labels May 8, 2024
Copy link
Contributor

github-actions bot commented May 8, 2024

Preview URLs

(comment last updated: 2024-05-22 01:39:52)

Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine as is, so approved.

Made a few grammar suggestions and see also suggestion for your consideration, so will let you merge.

files/en-us/glossary/digital_signature/index.md Outdated Show resolved Hide resolved
files/en-us/glossary/digital_signature/index.md Outdated Show resolved Hide resolved
files/en-us/glossary/digital_signature/index.md Outdated Show resolved Hide resolved

- {{glossary("Digital certificate")}}
- {{glossary("Hash")}}
- {{glossary("Public-key cryptography")}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These three are already in the document. This might be a good place to add links to the security docs you're writing instead, but it's ok to leave these here too.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fair. I never know whether to include relevant links that are already mentioned inline. But I will leave them here now, since they don't seem to be doing any harm.

Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>
@wbamberg wbamberg merged commit 1c8d482 into mdn:main May 22, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Glossary Glossary entries size/s 6-50 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants