Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the CSSUnitValue wrong link #33508

Merged
merged 5 commits into from May 14, 2024

Conversation

T34-active
Copy link
Contributor

Description

Motivation

Additional details

Related issues and pull requests

@T34-active T34-active requested a review from a team as a code owner May 9, 2024 02:43
@T34-active T34-active requested review from wbamberg and removed request for a team May 9, 2024 02:43
@github-actions github-actions bot added the Content:WebAPI Web API docs label May 9, 2024
@T34-active T34-active changed the title fix CSSUnitValue wrong link fix the CSSUnitValue wrong link May 9, 2024
@github-actions github-actions bot added the size/xs 0-5 LoC changed label May 9, 2024
Copy link
Contributor

github-actions bot commented May 9, 2024

Preview URLs

Flaws (2)

Note! 1 document with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/CSS_Object_Model
Title: CSS Object Model (CSSOM)
Flaw count: 2

  • macros:
    • /en-US/docs/Web/API/CSSFontFeatureValuesMap does not exist
    • /en-US/docs/Web/API/CSSMarginRule does not exist

(comment last updated: 2024-05-14 17:19:22)

Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR! I think this is the wrong fix though.

I don't think the fragment should be "css_typed_object_model_experimental", it should just be "css_typed_object_model". The "_experimental" bit is an artifact of the use of the {{experimental_inline}} macro in the header, which we are not supposed to do. In fact this also seems just wrong since many of these interfaces are not experimental any more (for instance, this one isn't).

So the right fix would be to remove the {{experimental_inline}} macro from the header, and the {{SeeCompatTable}} macro below it, and check each interface listed to see if it is really experimental or not.

Also, the link text in the CSSUnitValue page should be "CSS Typed Object Model API".

Please let me know if you'd like to do this, I'm happy to take care of it otherwise!

@T34-active
Copy link
Contributor Author

Thanks for your PR! I think this is the wrong fix though.

I don't think the fragment should be "css_typed_object_model_experimental", it should just be "css_typed_object_model". The "_experimental" bit is an artifact of the use of the {{experimental_inline}} macro in the header, which we are not supposed to do. In fact this also seems just wrong since many of these interfaces are not experimental any more (for instance, this one isn't).

So the right fix would be to remove the {{experimental_inline}} macro from the header, and the {{SeeCompatTable}} macro below it, and check each interface listed to see if it is really experimental or not.

Also, the link text in the CSSUnitValue page should be "CSS Typed Object Model API".

Please let me know if you'd like to do this, I'm happy to take care of it otherwise!

/cc @wbamberg i'm update this content, you can watch this #33599

@T34-active T34-active requested a review from wbamberg May 14, 2024 02:58
Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thank you @T34-active , and thanks for fixing all the other macro calls in the other PR <3.

@wbamberg wbamberg merged commit 23d4eb9 into mdn:main May 14, 2024
8 checks passed
@T34-active T34-active deleted the cssunitvalue_wrong_link_20240509 branch May 15, 2024 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebAPI Web API docs size/xs 0-5 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants