New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix the CSSUnitValue wrong link #33508
fix the CSSUnitValue wrong link #33508
Conversation
Preview URLs Flaws (2)Note! 1 document with no flaws that don't need to be listed. 🎉 URL:
(comment last updated: 2024-05-14 17:19:22) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR! I think this is the wrong fix though.
I don't think the fragment should be "css_typed_object_model_experimental", it should just be "css_typed_object_model". The "_experimental" bit is an artifact of the use of the {{experimental_inline}} macro in the header, which we are not supposed to do. In fact this also seems just wrong since many of these interfaces are not experimental any more (for instance, this one isn't).
So the right fix would be to remove the {{experimental_inline}} macro from the header, and the {{SeeCompatTable}} macro below it, and check each interface listed to see if it is really experimental or not.
Also, the link text in the CSSUnitValue page should be "CSS Typed Object Model API".
Please let me know if you'd like to do this, I'm happy to take care of it otherwise!
/cc @wbamberg i'm update this content, you can watch this #33599 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 thank you @T34-active , and thanks for fixing all the other macro calls in the other PR <3.
Description
Motivation
Additional details
Related issues and pull requests