feat: improvments on decryption #33513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PassionPenguin
requested review from
chrisdavidmills
and removed request for
a team
github-actions
bot
added
Content:Glossary
|
Preview URLs (comment last updated: 2024-05-14 01:30:01) |
wbamberg
requested changes
May 9, 2024
|
|
||
|  | ||
|
|
||
| Decryption is the reverse of {{glossary("encryption")}} and if the key stays secret, decryption without knowing the specific secret, decryption is mathematically hard to perform. How hard depends on the security of the cryptographic algorithm chosen and evolves with the progress of {{glossary("cryptanalysis")}}. | ||
| Decryption is the reverse process of {{glossary("encryption")}} and if the key stays secret, decryption without knowing the specific secret, decryption is mathematically hard to perform, depending on the security of the cryptographic algorithm chosen and evolves with the progress of {{glossary("cryptanalysis")}}. |
There was a problem hiding this comment.
Suggested change
| Decryption is the reverse process of {{glossary("encryption")}} and if the key stays secret, decryption without knowing the specific secret, decryption is mathematically hard to perform, depending on the security of the cryptographic algorithm chosen and evolves with the progress of {{glossary("cryptanalysis")}}. | |
| Decryption is the reverse process of {{glossary("encryption")}} and if the key stays secret, is mathematically hard to perform. How hard depends on the security of the cryptographic algorithm chosen and evolves with the progress of {{glossary("cryptanalysis")}}. |
- there was another error in this sentence, " decryption without knowing the specific secret"
- I think the original 2-sentence form was fine, and the PR introduced a new error ("evolves" no longer made sense).
There was a problem hiding this comment.
in the original context, evolves should means as cryptanalysis develops? so can we just say, the progress of that develpment(research)?
Suggested change
| Decryption is the reverse process of {{glossary("encryption")}} and if the key stays secret, decryption without knowing the specific secret, decryption is mathematically hard to perform, depending on the security of the cryptographic algorithm chosen and evolves with the progress of {{glossary("cryptanalysis")}}. | |
| Decryption is the reverse process of {{glossary("encryption")}} and if the key stays secret, is mathematically hard to perform. The difficulty depends on the security of the cryptographic algorithm chosen and the research progress of {{glossary("cryptanalysis")}}. |
Co-authored-by: wbamberg <will@bootbonnet.ca>
wbamberg
reviewed
May 13, 2024
Co-authored-by: wbamberg <will@bootbonnet.ca>
wbamberg
approved these changes
May 14, 2024
PassionPenguin
added a commit
to PassionPenguin/content
that referenced
this pull request
May 14, 2024
This reverts commit 5b7f958.
PassionPenguin
added a commit
to PassionPenguin/translated-content
that referenced
this pull request
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Deletion
Modification