Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Baseline glossary entry: mention accessibility and other considerations #33515

Merged
merged 2 commits into from May 13, 2024
Merged

Baseline glossary entry: mention accessibility and other considerations #33515

merged 2 commits into from May 13, 2024

Conversation

ddbeck
Copy link
Contributor

@ddbeck ddbeck commented May 9, 2024

Description

Mention the need for accessibility and other testing in the Baseline Extra considerations section.

Motivation

There have been a few questions about whether Baseline covers assistive technology. It only covers browser support, not other plugins and tools. This change makes that more explicit.

Additional details

Related issues and pull requests

Fixes mdn/yari#10350

@ddbeck ddbeck requested a review from a team as a code owner May 9, 2024 15:59
@ddbeck ddbeck requested review from bsmth and removed request for a team May 9, 2024 15:59
@github-actions github-actions bot added the Content:Glossary Glossary entries label May 9, 2024
@ddbeck ddbeck mentioned this pull request May 9, 2024
Closed
3 tasks
@github-actions github-actions bot added the size/s 6-50 LoC changed label May 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 9, 2024 •
edited

Preview URLs

External URLs (2)

URL: /en-US/docs/Glossary/Baseline/Compatibility
Title: Baseline (compatibility)

(comment last updated: 2024-05-10 13:56:51)

bsmth
bsmth approved these changes May 10, 2024
View reviewed changes
Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Daniel. I'm approving, but there's some comments if you want to consider & incorporate some changes! 👍🏻

@ddbeck @bsmth
Apply copy editing suggestions
618e5b1 
Co-authored-by: Brian Thomas Smith <brian@smith.berlin>
ddbeck
ddbeck commented May 10, 2024
View reviewed changes
Copy link
Contributor Author

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Brian—all good edits. One follow up question for you.

files/en-us/glossary/baseline/compatibility/index.md Show resolved Hide resolved
@bsmth
Copy link
Member

bsmth commented May 13, 2024

Super, thank you! Let's merge this 👍🏻

@bsmth bsmth merged commit 0b60142 into mdn:main May 13, 2024
8 checks passed
@ddbeck ddbeck deleted the fix-yari-10350 branch May 14, 2024 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsmth bsmth bsmth approved these changes

Assignees
No one assigned
Labels
Content:Glossary Glossary entries size/s 6-50 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider adding an accessibility disclaimer to the Baseline badge
2 participants
@ddbeck @bsmth