Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ff126 RelNote: Selection.getComposedRanges() and friends #33528

Merged

Conversation

hamishwillee
Copy link
Collaborator

FF126 adds partial support for Selection across shadow DOM ranges. This includes (full) support for Selection.direction and preview support for Selection.getComposedRanges() and associated properties/methods.

This adds appropriate release notes and experimental features updates.

Associated docs changes can be tracked in #33180

PS Also removes clonable option of shadow dom as experimental feature, as that was released.

@hamishwillee hamishwillee requested a review from a team as a code owner May 10, 2024 04:35
@hamishwillee hamishwillee requested review from dipikabh and removed request for a team May 10, 2024 04:35
@github-actions github-actions bot added Content:Firefox Content in the Mozilla/Firefox subtree size/m 51-500 LoC changed labels May 10, 2024
@hamishwillee hamishwillee changed the title Ff126 RelNote: #33180relnote selection getcomposedranges Ff126 RelNote: Selection.getComposedRanges() and friends May 10, 2024
Copy link
Contributor

github-actions bot commented May 10, 2024

Preview URLs

Flaws (6)

URL: /en-US/docs/Mozilla/Firefox/Releases/126
Title: Firefox 126 for developers
Flaw count: 3

  • macros:
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/Add-ons/WebExtensions
    • /en-US/Add-ons/Themes does not exist
  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/basic-shape/shape

URL: /en-US/docs/Mozilla/Firefox/Experimental_features
Title: Experimental features in Firefox
Flaw count: 3

  • macros:
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/Add-ons/WebExtensions
    • /en-US/Add-ons/Themes does not exist
  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/basic-shape/shape
External URLs (3)

URL: /en-US/docs/Mozilla/Firefox/Releases/126
Title: Firefox 126 for developers


URL: /en-US/docs/Mozilla/Firefox/Experimental_features
Title: Experimental features in Firefox

(comment last updated: 2024-05-13 22:54:18)

Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @hamishwillee. I've pointed some nits that you can choose to apply. This is good to go after your tweaks.

files/en-us/mozilla/firefox/experimental_features/index.md Outdated Show resolved Hide resolved
files/en-us/mozilla/firefox/releases/126/index.md Outdated Show resolved Hide resolved
Copy link
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
@hamishwillee
Copy link
Collaborator Author

Thanks @dipikabh - nit-fixes applied :-)

@hamishwillee hamishwillee merged commit 4b0ab74 into mdn:main May 13, 2024
8 checks passed
@hamishwillee hamishwillee deleted the ff126relnote_selection_getcomposedranges branch May 13, 2024 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Firefox Content in the Mozilla/Firefox subtree size/m 51-500 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants