Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add links to new guide and glossary pages #33531

Merged
merged 13 commits into from May 13, 2024
Merged

Add links to new guide and glossary pages #33531

merged 13 commits into from May 13, 2024

Conversation

estelle
Copy link
Member

@estelle estelle commented May 10, 2024 •
edited

Aspect ratio guide page has been added
Aspect ratio glossary page has been added as well.

This PR adds links to those two new pages.

Also added a ## see also section to the CSS images module page

Merge after #33461 is merged

@estelle estelle requested review from a team as code owners May 10, 2024 05:58
@estelle estelle requested review from dipikabh and removed request for a team May 10, 2024 05:58
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs Content:Learn Learning area docs Content:Glossary Glossary entries size/s 6-50 LoC changed labels May 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 10, 2024 •
edited

Preview URLs (12 pages)
Flaws (33)

URL: /en-US/docs/Learn/Performance/Multimedia
Title: Multimedia: Images
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/CSS_box_sizing/Understanding_aspect-ratio#adjusting_aspect_ratios_of_replaced_elements

URL: /en-US/docs/Glossary/Aspect_ratio
Title: Aspect ratio
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/CSS_box_sizing/Understanding_aspect-ratio

URL: /en-US/docs/Web/CSS/CSS_images
Title: CSS images
Flaw count: 3

  • macros:
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn//CSS
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn//Getting_started_with_the_web/CSS_basics
  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/CSS_box_sizing/Understanding_aspect-ratio

URL: /en-US/docs/Web/CSS/aspect-ratio
Title: aspect-ratio
Flaw count: 3

  • macros:
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn//CSS
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn//Getting_started_with_the_web/CSS_basics
  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/CSS_box_sizing/Understanding_aspect-ratio

URL: /en-US/docs/Web/CSS/@media/aspect-ratio
Title: aspect-ratio
Flaw count: 3

  • macros:
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn//CSS
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn//Getting_started_with_the_web/CSS_basics
  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/CSS_box_sizing/Understanding_aspect-ratio

URL: /en-US/docs/Web/CSS/@media/device-aspect-ratio
Title: device-aspect-ratio
Flaw count: 2

  • macros:
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn//CSS
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn//Getting_started_with_the_web/CSS_basics

URL: /en-US/docs/Web/CSS/CSS_box_model
Title: CSS box model
Flaw count: 3

  • macros:
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn//CSS
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn//Getting_started_with_the_web/CSS_basics
  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/CSS_box_sizing/Understanding_aspect-ratio

URL: /en-US/docs/Web/CSS/ratio
Title: <ratio>
Flaw count: 3

  • macros:
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn//CSS
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn//Getting_started_with_the_web/CSS_basics
  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/CSS_box_sizing/Understanding_aspect-ratio

URL: /en-US/docs/Web/CSS/object-fit
Title: object-fit
Flaw count: 3

  • macros:
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn//CSS
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn//Getting_started_with_the_web/CSS_basics
  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/CSS_box_sizing/Understanding_aspect-ratio

URL: /en-US/docs/Web/CSS/CSS_containment
Title: CSS containment
Flaw count: 3

  • macros:
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn//CSS
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn//Getting_started_with_the_web/CSS_basics
  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/CSS_box_sizing/Understanding_aspect-ratio

URL: /en-US/docs/Web/CSS/CSS_containment/Container_size_and_style_queries
Title: Using container size and style queries
Flaw count: 5

  • macros:
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn//CSS
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn//Getting_started_with_the_web/CSS_basics
    • /en-US/docs/Web/API/HTMLInputElement/value does not exist
    • /en-US/docs/Web/API/HTMLInputElement/checked does not exist
  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/CSS_box_sizing/Understanding_aspect-ratio

URL: /en-US/docs/Web/CSS/CSS_box_sizing
Title: CSS box sizing
Flaw count: 3

  • macros:
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn//CSS
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn//Getting_started_with_the_web/CSS_basics
  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/CSS_box_sizing/Understanding_aspect-ratio

(comment last updated: 2024-05-10 06:09:31)

@estelle estelle mentioned this pull request May 10, 2024
Closed
21 tasks
teoli2003
teoli2003 approved these changes May 13, 2024
View reviewed changes
Copy link
Member

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@teoli2003 teoli2003 merged commit 2ef2c90 into mdn:main May 13, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teoli2003 teoli2003 teoli2003 approved these changes

@dipikabh dipikabh Awaiting requested review from dipikabh dipikabh is a code owner automatically assigned from mdn/yari-content-css

Assignees
No one assigned
Labels
Content:CSS Cascading Style Sheets docs Content:Glossary Glossary entries Content:Learn Learning area docs size/s 6-50 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@estelle @teoli2003