Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: Fix exception section title #33551

Merged
merged 2 commits into from May 13, 2024
Merged

style: Fix exception section title #33551

merged 2 commits into from May 13, 2024

Conversation

skyclouds2001
Copy link
Contributor

@skyclouds2001 skyclouds2001 commented May 11, 2024 •
edited

Description

in web api method page (and web api constructor page) the ### Exceptions section should be a sub-section of ## Syntax

also fix ### Exception to ### Exceptions

Motivation

Additional details

Related issues and pull requests

relates to mdn/translated-content#20165

@github-actions github-actions bot added Content:WebAPI Web API docs size/s 6-50 LoC changed labels May 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 11, 2024 •
edited

Preview URLs (19 pages)

(comment last updated: 2024-05-11 12:59:18)

@skyclouds2001 skyclouds2001 marked this pull request as ready for review May 11, 2024 12:49
@skyclouds2001 skyclouds2001 requested a review from a team as a code owner May 11, 2024 12:49
@skyclouds2001 skyclouds2001 requested review from wbamberg and removed request for a team May 11, 2024 12:49
@skyclouds2001 skyclouds2001 changed the title Fix exception section title style: Fix exception section title May 11, 2024
This was referenced May 12, 2024
Merged
Merged
Merged
Merged
hamishwillee
hamishwillee approved these changes May 13, 2024
View reviewed changes
Copy link
Collaborator

@hamishwillee hamishwillee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@hamishwillee hamishwillee merged commit 502e8c3 into mdn:main May 13, 2024
8 checks passed
@skyclouds2001 skyclouds2001 deleted the exception-section branch May 13, 2024 04:44
@mdn mdn deleted a comment from nooor-5 May 23, 2024
@mdn mdn deleted a comment from nooor-5 May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hamishwillee hamishwillee hamishwillee approved these changes

@wbamberg wbamberg Awaiting requested review from wbamberg wbamberg is a code owner automatically assigned from mdn/yari-content-web-api

Assignees
No one assigned
Labels
Content:WebAPI Web API docs size/s 6-50 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@skyclouds2001 @hamishwillee