Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requeststorageaccessfor: Fix claim about gestures #33567

Merged
merged 1 commit into from May 14, 2024

Conversation

tgr
Copy link
Contributor

@tgr tgr commented May 12, 2024

It is the top-level content, not the embedded content, that needs to be processing a user gesture.
See https://privacycg.github.io/requestStorageAccessFor/#dom-document-requeststorageaccessfor step 12 (but also common sense, the goal of requestStorageAccessFor is to allow storage access in requests which cannot execute Javascript, like an AJAX request or invisible pixel, and those do not have a concept of user gestures either.)

@tgr tgr requested a review from a team as a code owner May 12, 2024 19:08
@tgr tgr requested review from wbamberg and removed request for a team May 12, 2024 19:08
@github-actions github-actions bot added Content:WebAPI Web API docs size/xs 0-5 LoC changed labels May 12, 2024
Copy link
Contributor

Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thank you for the fix, @tgr !

@wbamberg wbamberg merged commit a682f6f into mdn:main May 14, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebAPI Web API docs size/xs 0-5 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants