enhance(design): inverse menu highlight + increase contrast #11061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dark theme: 4.67 (menu) / 5.31 (curriculum module list tabs). Light theme: 4.51 (menu / curriculum module list tabs).
Active item gets darker (light theme) or brighter (dark theme) color.
This also applies to the New/Beta pills.
caugner
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
(MP-1103)
Problem
Solution
Inverse the menu highlighting, reducing the opacity of the inactive items using
opacity: 0.775, and increasing the contrast of the active item by switching from--text-secondaryto--text-primary, which is the same color used for the MDN logo.Note: Also removes the
--text-activevariable, which is no longer used.Screenshots
How did you test this change?
Ran
yarn devand compared http://localhost:3000/en-US/docs/Learn locally against https://developer.mozilla.org/en-US/docs/Learn.