Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance(sidebar,toc): improve style of current item #11063

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

enhance(sidebar,toc): improve style of current item #11063

wants to merge 7 commits into from

Conversation

caugner
Copy link
Contributor

@caugner caugner commented May 3, 2024 •
edited

Summary

(MP-1105)

Problem

  1. The borders aren't rounded, unlike other elements.
  2. The items take up all available width.

Solution

  1. Round the right borders.
  2. Reduce the width.

Screenshots

Before

image

After

image

How did you test this change?

Ran yarn dev and viewed http://localhost:3000/en-US/docs/Learn/CSS/First_steps#guides locally, comparing it against https://developer.mozilla.org/en-US/docs/Learn/CSS/First_steps#guides.

@caugner caugner requested a review from a team as a code owner May 3, 2024 12:29
@caugner caugner added the ux make the user experience awesome label May 3, 2024
@caugner caugner marked this pull request as draft May 20, 2024 16:21
@caugner caugner marked this pull request as draft May 20, 2024 16:21
@caugner caugner marked this pull request as ready for review May 20, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ux make the user experience awesome
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@caugner