Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(css-syntax): fix some minor css syntax bugs #11070

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

fiji-flo
Copy link
Contributor

@fiji-flo fiji-flo commented May 6, 2024

Summary

This includes some minor fixes for CSS syntax :

  • link <length [0,∞]> to length
  • link ! in [ a | b ]!
  • prefer main spec for at sytntax rule descriptors

How did you test this change?

See https://static.fiji-flo.de/diff-part-2.html

  • -webkit-line-clamp/index.json is an example <integer [1,∞]>
  • background-position-x/index.json is an example for the ]! fix
  • @font-face/ascent-override/index.json is an example for using css-fonts instead of css-fonts-5

- link <length [0,infinity]> to length
- link ! in [ a | b ]!
- prefer main spec for  at sytntax rule descriptors
@fiji-flo fiji-flo requested a review from wbamberg May 6, 2024 08:35
@fiji-flo fiji-flo requested a review from a team as a code owner May 6, 2024 08:35
@github-actions github-actions bot added the macros tracking issues related to kumascript macros label May 6, 2024
@fiji-flo
Copy link
Contributor Author

fiji-flo commented May 8, 2024

@wbamberg are you fine with these? Especially the last one:

  • prefer main spec for at sytntax rule descriptors

@wbamberg wbamberg removed their request for review May 14, 2024 23:49
@dipikabh
Copy link
Contributor

I took a quick look, @fiji-flo. The results in the right column on https://static.fiji-flo.de/diff-part-2.html look good.

To confirm, for "@page/index.json", will the part "Where the includes:" be included in the Formal syntax?

@fiji-flo
Copy link
Contributor Author

No that's always the whole section of https://developer.mozilla.org/en-US/docs/Web/CSS/@page#formal_syntax.

@dipikabh
Copy link
Contributor

We should fix this in content (I'll make a note) to remove the hand-curated part following https://developer.mozilla.org/en-US/docs/Web/CSS/@page#formal_syntax. <page-body> is no longer relevant, and <pseudo-page> is getting covered in the syntax.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
macros tracking issues related to kumascript macros
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants