Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Weird test failures related to puppeteer #3696

Merged
merged 3 commits into from
May 4, 2021
Merged

Weird test failures related to puppeteer #3696

merged 3 commits into from
May 4, 2021

Conversation

peterbe
Copy link
Contributor

@peterbe peterbe commented May 4, 2021

Fixes #3694

This seems to be making things better.

@peterbe
Copy link
Contributor Author

peterbe commented May 4, 2021

Sure enough. The minute I went back to main (and run yarn install which gives me puppeteer 9.1.0) it fails again.

@nschonni Can you look at my dependabot.yml config?

@Gregoor There's not much to review here but to help confirm my conclusion.

@peterbe peterbe marked this pull request as ready for review May 4, 2021 14:12
@peterbe peterbe mentioned this pull request May 4, 2021
Merged
@peterbe peterbe requested a review from Gregoor May 4, 2021 14:15
@peterbe peterbe mentioned this pull request May 4, 2021
Closed
Gregoor
Gregoor approved these changes May 4, 2021
View reviewed changes
Copy link
Contributor

@Gregoor Gregoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great that they already have a PR fixing this, means we can update again soonish!

@peterbe peterbe merged commit 26ab69d into mdn:main May 4, 2021
@peterbe peterbe deleted the 3694-weird-test-failures-related-to-puppeteer branch May 4, 2021 18:39
peterbe added a commit to peterbe/yari that referenced this pull request Jun 1, 2021
@peterbe
Weird test failures related to puppeteer (mdn#3696)
5a8ae5d 
* Weird test failures related to puppeteer

Fixes mdn#3694

* tell dependabot to not upgrade puppeteer 9.x automatically

* specific about 9.1.x
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gregoor Gregoor Gregoor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Weird test failures related to puppeteer
2 participants
@peterbe @Gregoor