-
Notifications
You must be signed in to change notification settings - Fork 472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Prettier from 2.8.8 to 3.0.0 #9304
Conversation
Oh...well, apparently, the last commit I pushed fixed it all up, so never mind my last comment. 😛 |
This pull request has merge conflicts that must be resolved before it can be merged. |
@LeoMcA, I see that you're around -- are you available and willing to review and merge this quickly by chance? (Highly recommend reviewing by commit since Prettier formatting also has to be run in the same go...) |
@queengooborg taking a look, but first up: I reckon now's not the time to make the Could you configure |
1bdff58
to
5a9af2b
Compare
That's a fair point, since most of the formatting changes are from adding trailing commas. There are still some other changes, so I've included that commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just the one change:
Co-authored-by: Leo McArdle <leo@mca.is>
This PR bumps Prettier from 2.8.8 to 3.0.0, and then fixes issues with the content commands caused by changes to the Prettier API. In Prettier v3.0, the
format()
command became asynchronous, so we were returning a Promise every so often, which caused errors when running commands. This PR aims to fix this by adding anawait
, and making the rest of the function chain asynchronous.Note: because the content repositories use Prettier 3.0.0, these commands are broken regardless of the Prettier version Yari is requesting.
Note: because Prettier has changed its defaults, the formatting output has also changed. TO pass linting, all files had to be formatted, which unfortunately means a greater risk of merge conflicts. Since this is a critical bug fix, it should be merged quickly anyways.