Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make short codes function conditional. #1088

Merged
merged 3 commits into from Jul 29, 2020

Conversation

ankeetmaini
Copy link
Contributor

Closes #721

@vercel
Copy link

vercel bot commented May 27, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/mdx/mdx/gkhnv9lln
✅ Preview: https://mdx-git-fork-ankeetmaini-remve-shortcode-if-no-shortcodes.mdx.vercel.app

@vercel vercel bot temporarily deployed to Preview May 27, 2020 08:00 Inactive
@vercel vercel bot temporarily deployed to Preview May 30, 2020 15:03 Inactive
@JounQin JounQin requested a review from johno July 15, 2020 11:00
@vercel vercel bot temporarily deployed to Preview July 29, 2020 21:13 Inactive
Copy link
Member

@johno johno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

😻😻😻

@johno johno merged commit 7454a69 into mdx-js:master Jul 29, 2020
johno added a commit to gatsbyjs/gatsby that referenced this pull request Jul 30, 2020
Starting in version 1.6.16, the makeShortcode function
is only added to compiled MDX when it is needed. This
caused the gatsby-plugin-mdx snapshots to fall out of
date. MDX is no bumped to 1.6.16 with the snapshots
updated.

Related:

- #24595 (comment)
- mdx-js/mdx#1088
gatsbybot pushed a commit to gatsbyjs/gatsby that referenced this pull request Jul 30, 2020
Starting in version 1.6.16, the makeShortcode function
is only added to compiled MDX when it is needed. This
caused the gatsby-plugin-mdx snapshots to fall out of
date. MDX is no bumped to 1.6.16 with the snapshots
updated.

Related:

- #24595 (comment)
- mdx-js/mdx#1088
gatsbybot pushed a commit to gatsbyjs/gatsby-starter-blog that referenced this pull request Jul 30, 2020
Starting in version 1.6.16, the makeShortcode function
is only added to compiled MDX when it is needed. This
caused the gatsby-plugin-mdx snapshots to fall out of
date. MDX is no bumped to 1.6.16 with the snapshots
updated.

Related:

- gatsbyjs/gatsby#24595 (comment)
- mdx-js/mdx#1088
gatsbybot pushed a commit to gatsbyjs/gatsby-starter-blog-theme-core that referenced this pull request Jul 30, 2020
Starting in version 1.6.16, the makeShortcode function
is only added to compiled MDX when it is needed. This
caused the gatsby-plugin-mdx snapshots to fall out of
date. MDX is no bumped to 1.6.16 with the snapshots
updated.

Related:

- gatsbyjs/gatsby#24595 (comment)
- mdx-js/mdx#1088
gatsbybot pushed a commit to gatsbyjs/gatsby-starter-minimal that referenced this pull request Jul 30, 2020
Starting in version 1.6.16, the makeShortcode function
is only added to compiled MDX when it is needed. This
caused the gatsby-plugin-mdx snapshots to fall out of
date. MDX is no bumped to 1.6.16 with the snapshots
updated.

Related:

- gatsbyjs/gatsby#24595 (comment)
- mdx-js/mdx#1088
gatsbybot pushed a commit to gatsbyjs/gatsby-starter-theme that referenced this pull request Jul 30, 2020
Starting in version 1.6.16, the makeShortcode function
is only added to compiled MDX when it is needed. This
caused the gatsby-plugin-mdx snapshots to fall out of
date. MDX is no bumped to 1.6.16 with the snapshots
updated.

Related:

- gatsbyjs/gatsby#24595 (comment)
- mdx-js/mdx#1088
cfchase pushed a commit to cfchase/gatsby-plugin-mdx that referenced this pull request Oct 30, 2020
Starting in version 1.6.16, the makeShortcode function
is only added to compiled MDX when it is needed. This
caused the gatsby-plugin-mdx snapshots to fall out of
date. MDX is no bumped to 1.6.16 with the snapshots
updated.

Related:

- gatsbyjs/gatsby#24595 (comment)
- mdx-js/mdx#1088
wooorm pushed a commit that referenced this pull request Dec 17, 2020
* Make short codes function conditional.

* Fix failing tests

Co-authored-by: John Otander <johnotander@gmail.com>
wooorm pushed a commit that referenced this pull request Dec 17, 2020
* Make short codes function conditional.

* Fix failing tests

Co-authored-by: John Otander <johnotander@gmail.com>
leonhiat added a commit to leonhiat/gatsby-starter-blog that referenced this pull request Oct 31, 2023
Starting in version 1.6.16, the makeShortcode function
is only added to compiled MDX when it is needed. This
caused the gatsby-plugin-mdx snapshots to fall out of
date. MDX is no bumped to 1.6.16 with the snapshots
updated.

Related:

- gatsbyjs/gatsby#24595 (comment)
- mdx-js/mdx#1088
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

If there are no shortcodes, don't add makeShortcode function to output JSX
2 participants