Add `module: node16` to `tsconfig.json` #2228

ChristianMurphy · 2023-01-16T20:51:47Z

Mostly ready, this will depend on some upstream changes being finished.
Rich-Harris/periscopic#19 and Rich-Harris/estree-walker#34

resolves #2211

vercel · 2023-01-16T20:51:52Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated
mdx	✅ Ready (Inspect)	Visit Preview	💬 Add your feedback	Feb 8, 2023 at 4:13PM (UTC)

ChristianMurphy · 2023-01-26T22:13:16Z

Upstream issues resolved, this is ready for review @mdx-js/maintainers

packages/mdx/lib/plugin/rehype-remove-raw.js

packages/mdx/tsconfig.json

codecov-commenter · 2023-02-08T16:14:03Z

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (f67a683) compared to base (b85947b).
Patch coverage: 100.00% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files

@@            Coverage Diff            @@
##              main     #2228   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           22        22           
  Lines         2064      2065    +1     
=========================================
+ Hits          2064      2065    +1

Impacted Files	Coverage Δ
packages/mdx/lib/evaluate.js	`100.00% <100.00%> (ø)`
packages/mdx/lib/plugin/rehype-remove-raw.js	`100.00% <100.00%> (ø)`

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

wooorm · 2023-02-08T16:25:21Z

Sweet, thanks!

wooorm · 2023-02-09T19:09:45Z

Thanks, released in 2.3.0

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@mdx-js/react](https://mdxjs.com) ([source](https://togithub.com/mdx-js/mdx)) | [`2.2.1` -> `2.3.0`](https://renovatebot.com/diffs/npm/@mdx-js%2freact/2.2.1/2.3.0) | [![age](https://badges.renovateapi.com/packages/npm/@mdx-js%2freact/2.3.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/@mdx-js%2freact/2.3.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/@mdx-js%2freact/2.3.0/compatibility-slim/2.2.1)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/@mdx-js%2freact/2.3.0/confidence-slim/2.2.1)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>mdx-js/mdx</summary> ### [`v2.3.0`](https://togithub.com/mdx-js/mdx/releases/tag/2.3.0) [Compare Source](https://togithub.com/mdx-js/mdx/compare/2.2.1...2.3.0) ##### Add - [`12e63e8`](https://togithub.com/mdx-js/mdx/commit/12e63e83) Add improved support for non-React frameworks by [@wooorm](https://togithub.com/wooorm) in [mdx-js/mdx#2255 ##### Fix - [`764d3a2`](https://togithub.com/mdx-js/mdx/commit/764d3a23) Remove whitespace between unraveled text nodes by [@wooorm](https://togithub.com/wooorm) in [mdx-js/mdx#2252 - [`3911148`](https://togithub.com/mdx-js/mdx/commit/39111484) Add `module: node16` to `tsconfig.json` by [@ChristianMurphy](https://togithub.com/ChristianMurphy) in [mdx-js/mdx#2228 - [`600b12a`](https://togithub.com/mdx-js/mdx/commit/600b12ad) Add inferring of `development` options from webpack loader mode by [@remcohaszing](https://togithub.com/remcohaszing) in [mdx-js/mdx#2201 ##### Community - [`f4d78be`](https://togithub.com/mdx-js/mdx/commit/f4d78be5) Add `recma-mdx-displayname` to list of plugins by [@domdomegg](https://togithub.com/domdomegg) in [mdx-js/mdx#2230 - [`1f551a4`](https://togithub.com/mdx-js/mdx/commit/1f551a4d) Add `remark-mdx-chartjs` to list of plugins by [@pangelani](https://togithub.com/pangelani) in [mdx-js/mdx#2221 ##### Misc - [`97b9d59`](https://togithub.com/mdx-js/mdx/commit/97b9d590) Refactor to improve docs by [@wooorm](https://togithub.com/wooorm) in [mdx-js/mdx#2254 - [`8f85b30`](https://togithub.com/mdx-js/mdx/commit/8f85b300) Refactor `tsconfig.json` by [@wooorm](https://togithub.com/wooorm) in [mdx-js/mdx#2250 - [`a17ac87`](https://togithub.com/mdx-js/mdx/commit/a17ac87c) Refactor wording by [@beeburrt](https://togithub.com/beeburrt) in [mdx-js/mdx#2214 **Full Changelog**: mdx-js/mdx@2.2.1...2.3.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/ziyadedher/ziyadedher).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@mdx-js/react](https://mdxjs.com) ([source](https://togithub.com/mdx-js/mdx)) | [`2.2.1` -> `2.3.0`](https://renovatebot.com/diffs/npm/@mdx-js%2freact/2.2.1/2.3.0) | [![age](https://badges.renovateapi.com/packages/npm/@mdx-js%2freact/2.3.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/@mdx-js%2freact/2.3.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/@mdx-js%2freact/2.3.0/compatibility-slim/2.2.1)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/@mdx-js%2freact/2.3.0/confidence-slim/2.2.1)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>mdx-js/mdx</summary> ### [`v2.3.0`](https://togithub.com/mdx-js/mdx/releases/tag/2.3.0) [Compare Source](https://togithub.com/mdx-js/mdx/compare/2.2.1...2.3.0) ##### Add - [`12e63e8`](https://togithub.com/mdx-js/mdx/commit/12e63e83) Add improved support for non-React frameworks by [@wooorm](https://togithub.com/wooorm) in [mdx-js/mdx#2255 ##### Fix - [`764d3a2`](https://togithub.com/mdx-js/mdx/commit/764d3a23) Remove whitespace between unraveled text nodes by [@wooorm](https://togithub.com/wooorm) in [mdx-js/mdx#2252 - [`3911148`](https://togithub.com/mdx-js/mdx/commit/39111484) Add `module: node16` to `tsconfig.json` by [@ChristianMurphy](https://togithub.com/ChristianMurphy) in [mdx-js/mdx#2228 - [`600b12a`](https://togithub.com/mdx-js/mdx/commit/600b12ad) Add inferring of `development` options from webpack loader mode by [@remcohaszing](https://togithub.com/remcohaszing) in [mdx-js/mdx#2201 ##### Community - [`f4d78be`](https://togithub.com/mdx-js/mdx/commit/f4d78be5) Add `recma-mdx-displayname` to list of plugins by [@domdomegg](https://togithub.com/domdomegg) in [mdx-js/mdx#2230 - [`1f551a4`](https://togithub.com/mdx-js/mdx/commit/1f551a4d) Add `remark-mdx-chartjs` to list of plugins by [@pangelani](https://togithub.com/pangelani) in [mdx-js/mdx#2221 ##### Misc - [`97b9d59`](https://togithub.com/mdx-js/mdx/commit/97b9d590) Refactor to improve docs by [@wooorm](https://togithub.com/wooorm) in [mdx-js/mdx#2254 - [`8f85b30`](https://togithub.com/mdx-js/mdx/commit/8f85b300) Refactor `tsconfig.json` by [@wooorm](https://togithub.com/wooorm) in [mdx-js/mdx#2250 - [`a17ac87`](https://togithub.com/mdx-js/mdx/commit/a17ac87c) Refactor wording by [@beeburrt](https://togithub.com/beeburrt) in [mdx-js/mdx#2214 **Full Changelog**: mdx-js/mdx@2.2.1...2.3.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/ziyadedher/ziyadedher).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

types: use node16 module resolution in typescript

9706ad7

vercel bot deployed to Preview January 16, 2023 20:53 View deployment

chore: update package lockfile, add ref to raw type

10bfd8b

ChristianMurphy marked this pull request as ready for review January 26, 2023 22:12

ChristianMurphy changed the title ~~[WIP] types: use node16 module resolution in typescript~~ types: use node16 module resolution in typescript Jan 26, 2023

vercel bot deployed to Preview January 26, 2023 22:14 View deployment

ChristianMurphy commented Jan 26, 2023

View reviewed changes

packages/mdx/lib/plugin/rehype-remove-raw.js Outdated Show resolved Hide resolved

vercel bot deployed to Preview January 27, 2023 21:28 View deployment

wooorm reviewed Feb 8, 2023

View reviewed changes

packages/mdx/tsconfig.json Outdated Show resolved Hide resolved

upgrade mdast util from hast, include import for raw type

746afe3

ChristianMurphy force-pushed the types/node16 branch from bd4c814 to 746afe3 Compare February 8, 2023 16:09

Merge branch 'main' of github.com:mdx-js/mdx into types/node16

f67a683

vercel bot deployed to Preview February 8, 2023 16:13 View deployment

wooorm approved these changes Feb 8, 2023

View reviewed changes

wooorm changed the title ~~types: use node16 module resolution in typescript~~ Add module: node16 to tsconfig.json Feb 8, 2023

wooorm merged commit 3911148 into mdx-js:main Feb 8, 2023

wooorm added the 💪 phase/solved Post is done label Feb 8, 2023

wooorm added the ☂️ area/types This affects typings label Feb 8, 2023

ChristianMurphy deleted the types/node16 branch February 9, 2023 19:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add `module: node16` to `tsconfig.json` #2228

Add `module: node16` to `tsconfig.json` #2228

ChristianMurphy commented Jan 16, 2023 •

edited

vercel bot commented Jan 16, 2023 •

edited

ChristianMurphy commented Jan 26, 2023

codecov-commenter commented Feb 8, 2023 •

edited

wooorm commented Feb 8, 2023

wooorm commented Feb 9, 2023

Add module: node16 to tsconfig.json #2228

Add module: node16 to tsconfig.json #2228

Conversation

ChristianMurphy commented Jan 16, 2023 • edited

vercel bot commented Jan 16, 2023 • edited

ChristianMurphy commented Jan 26, 2023

codecov-commenter commented Feb 8, 2023 • edited

Codecov Report

wooorm commented Feb 8, 2023

wooorm commented Feb 9, 2023

Add `module: node16` to `tsconfig.json` #2228

Add `module: node16` to `tsconfig.json` #2228

ChristianMurphy commented Jan 16, 2023 •

edited

vercel bot commented Jan 16, 2023 •

edited

codecov-commenter commented Feb 8, 2023 •

edited