Add improved support for non-React frameworks #2255

wooorm · 2023-02-09T18:50:13Z

React uses their own style of attributes (similar to the DOM), such as className instead of class.
Some ther frameworks don’t support that: they want you to pass class. Similarly, React wants WebkitBoxShadow, while other frameworks want -webkit-box-shadow.

This particularly becomes an issue around more complex things such as SVG.
With this commit, you can now configure the exact style that your particular framework accepts.

Closes GH-2247.

React uses their own style of attributes (similar to the DOM), such as `className` instead of `class`. Some ther frameworks don’t support that: they want you to pass `class`. Similarly, React wants `WebkitBoxShadow`, while other frameworks want `-webkit-box-shadow`. This particularly becomes an issue around more complex things such as SVG. With this commit, you can now configure the exact style that your particular framework accepts. Closes GH-2247.

vercel · 2023-02-09T18:50:21Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated
mdx	✅ Ready (Inspect)	Visit Preview	💬 Add your feedback	Feb 9, 2023 at 6:51PM (UTC)

DaniGuardiola · 2023-02-09T20:40:37Z

@wooorm after upgrading to 2.3.0 in my project, this didn't work, because hast-util-to-estree was still on the 2.2.1 version. Should the package.json entry be updated to "^2.3.0" maybe?

DaniGuardiola · 2023-02-09T20:43:24Z

Of course, running pnpm update --latest did bump it, but doesn't "^2.3.0" make it technically incompatible?

ChristianMurphy · 2023-02-09T20:47:58Z

@DaniGuardiola update your lockfile.
mdx allows and encourages the latest of the current major version line.

mdx/packages/mdx/package.json

Line 55 in 5f68330

"hast-util-to-estree": "^2.0.0",

We intentionally do NOT bump to versions like ^2.3.0 to allow package managers to de-duplicate more if an older version is used elsewhere.

That said, pnpm and yarn are known to try to unnecessarily lock older versions, prioritizing minimizing change above de-duplication.
In that case running the lockfile update command for the given package manager is the best approach to get the upgrade.

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@mdx-js/react](https://mdxjs.com) ([source](https://togithub.com/mdx-js/mdx)) | [`2.2.1` -> `2.3.0`](https://renovatebot.com/diffs/npm/@mdx-js%2freact/2.2.1/2.3.0) | [![age](https://badges.renovateapi.com/packages/npm/@mdx-js%2freact/2.3.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/@mdx-js%2freact/2.3.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/@mdx-js%2freact/2.3.0/compatibility-slim/2.2.1)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/@mdx-js%2freact/2.3.0/confidence-slim/2.2.1)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>mdx-js/mdx</summary> ### [`v2.3.0`](https://togithub.com/mdx-js/mdx/releases/tag/2.3.0) [Compare Source](https://togithub.com/mdx-js/mdx/compare/2.2.1...2.3.0) ##### Add - [`12e63e8`](https://togithub.com/mdx-js/mdx/commit/12e63e83) Add improved support for non-React frameworks by [@wooorm](https://togithub.com/wooorm) in [mdx-js/mdx#2255 ##### Fix - [`764d3a2`](https://togithub.com/mdx-js/mdx/commit/764d3a23) Remove whitespace between unraveled text nodes by [@wooorm](https://togithub.com/wooorm) in [mdx-js/mdx#2252 - [`3911148`](https://togithub.com/mdx-js/mdx/commit/39111484) Add `module: node16` to `tsconfig.json` by [@ChristianMurphy](https://togithub.com/ChristianMurphy) in [mdx-js/mdx#2228 - [`600b12a`](https://togithub.com/mdx-js/mdx/commit/600b12ad) Add inferring of `development` options from webpack loader mode by [@remcohaszing](https://togithub.com/remcohaszing) in [mdx-js/mdx#2201 ##### Community - [`f4d78be`](https://togithub.com/mdx-js/mdx/commit/f4d78be5) Add `recma-mdx-displayname` to list of plugins by [@domdomegg](https://togithub.com/domdomegg) in [mdx-js/mdx#2230 - [`1f551a4`](https://togithub.com/mdx-js/mdx/commit/1f551a4d) Add `remark-mdx-chartjs` to list of plugins by [@pangelani](https://togithub.com/pangelani) in [mdx-js/mdx#2221 ##### Misc - [`97b9d59`](https://togithub.com/mdx-js/mdx/commit/97b9d590) Refactor to improve docs by [@wooorm](https://togithub.com/wooorm) in [mdx-js/mdx#2254 - [`8f85b30`](https://togithub.com/mdx-js/mdx/commit/8f85b300) Refactor `tsconfig.json` by [@wooorm](https://togithub.com/wooorm) in [mdx-js/mdx#2250 - [`a17ac87`](https://togithub.com/mdx-js/mdx/commit/a17ac87c) Refactor wording by [@beeburrt](https://togithub.com/beeburrt) in [mdx-js/mdx#2214 **Full Changelog**: mdx-js/mdx@2.2.1...2.3.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/ziyadedher/ziyadedher).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@mdx-js/react](https://mdxjs.com) ([source](https://togithub.com/mdx-js/mdx)) | [`2.2.1` -> `2.3.0`](https://renovatebot.com/diffs/npm/@mdx-js%2freact/2.2.1/2.3.0) | [![age](https://badges.renovateapi.com/packages/npm/@mdx-js%2freact/2.3.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/@mdx-js%2freact/2.3.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/@mdx-js%2freact/2.3.0/compatibility-slim/2.2.1)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/@mdx-js%2freact/2.3.0/confidence-slim/2.2.1)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>mdx-js/mdx</summary> ### [`v2.3.0`](https://togithub.com/mdx-js/mdx/releases/tag/2.3.0) [Compare Source](https://togithub.com/mdx-js/mdx/compare/2.2.1...2.3.0) ##### Add - [`12e63e8`](https://togithub.com/mdx-js/mdx/commit/12e63e83) Add improved support for non-React frameworks by [@wooorm](https://togithub.com/wooorm) in [mdx-js/mdx#2255 ##### Fix - [`764d3a2`](https://togithub.com/mdx-js/mdx/commit/764d3a23) Remove whitespace between unraveled text nodes by [@wooorm](https://togithub.com/wooorm) in [mdx-js/mdx#2252 - [`3911148`](https://togithub.com/mdx-js/mdx/commit/39111484) Add `module: node16` to `tsconfig.json` by [@ChristianMurphy](https://togithub.com/ChristianMurphy) in [mdx-js/mdx#2228 - [`600b12a`](https://togithub.com/mdx-js/mdx/commit/600b12ad) Add inferring of `development` options from webpack loader mode by [@remcohaszing](https://togithub.com/remcohaszing) in [mdx-js/mdx#2201 ##### Community - [`f4d78be`](https://togithub.com/mdx-js/mdx/commit/f4d78be5) Add `recma-mdx-displayname` to list of plugins by [@domdomegg](https://togithub.com/domdomegg) in [mdx-js/mdx#2230 - [`1f551a4`](https://togithub.com/mdx-js/mdx/commit/1f551a4d) Add `remark-mdx-chartjs` to list of plugins by [@pangelani](https://togithub.com/pangelani) in [mdx-js/mdx#2221 ##### Misc - [`97b9d59`](https://togithub.com/mdx-js/mdx/commit/97b9d590) Refactor to improve docs by [@wooorm](https://togithub.com/wooorm) in [mdx-js/mdx#2254 - [`8f85b30`](https://togithub.com/mdx-js/mdx/commit/8f85b300) Refactor `tsconfig.json` by [@wooorm](https://togithub.com/wooorm) in [mdx-js/mdx#2250 - [`a17ac87`](https://togithub.com/mdx-js/mdx/commit/a17ac87c) Refactor wording by [@beeburrt](https://togithub.com/beeburrt) in [mdx-js/mdx#2214 **Full Changelog**: mdx-js/mdx@2.2.1...2.3.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/ziyadedher/ziyadedher).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

wooorm added 🦋 type/enhancement This is great to have 🧒 semver/minor This is backwards-compatible change labels Feb 9, 2023

vercel bot deployed to Preview February 9, 2023 18:51 View deployment

ChristianMurphy approved these changes Feb 9, 2023

View reviewed changes

wooorm merged commit 12e63e8 into main Feb 9, 2023

wooorm deleted the non-react branch February 9, 2023 19:00

wooorm added the 💪 phase/solved Post is done label Feb 9, 2023

bluwy mentioned this pull request Feb 14, 2023

Support rehype plugins that inject namespaced attributes withastro/astro#6243

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add improved support for non-React frameworks #2255

Add improved support for non-React frameworks #2255

wooorm commented Feb 9, 2023

vercel bot commented Feb 9, 2023 •

edited

DaniGuardiola commented Feb 9, 2023

DaniGuardiola commented Feb 9, 2023

ChristianMurphy commented Feb 9, 2023 •

edited

Add improved support for non-React frameworks #2255

Add improved support for non-React frameworks #2255

Conversation

wooorm commented Feb 9, 2023

vercel bot commented Feb 9, 2023 • edited

DaniGuardiola commented Feb 9, 2023

DaniGuardiola commented Feb 9, 2023

ChristianMurphy commented Feb 9, 2023 • edited

vercel bot commented Feb 9, 2023 •

edited

ChristianMurphy commented Feb 9, 2023 •

edited