Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rel=sponsored to sponsor links #2439

Conversation

ChristianMurphy
Copy link
Member

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and couldn’t find anything (or linked relevant results below)
  • If applicable, I’ve added docs and tests

Description of changes

Matching annotations to the ones used on https://unifiedjs.com/

Copy link

vercel bot commented Feb 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mdx ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 12, 2024 7:58pm

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (908ff45) 100.00% compared to head (5eaf608) 100.00%.
Report is 7 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #2439   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           23        23           
  Lines         2693      2694    +1     
  Branches         2         2           
=========================================
+ Hits          2693      2694    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@remcohaszing remcohaszing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is MDX, and not some markdown rendered on GitHub, perhaps we could leverage a React component. We could even avoid using a table altogether.

I approved, because I’m fine with this change regardless.

@wooorm
Copy link
Member

wooorm commented Feb 13, 2024

This is copy/pasted from the readmes when everything is changed. That’s why it’s nice to have it similar to the rest, minimal changes.

I am not so worried about spam here: these are top doners who I am in contact with. Not random iffy betting things or so.

@wooorm wooorm changed the title docs: annotate sponsor links with rel sponsored Add rel=sponsored to sponsor links Feb 13, 2024
@wooorm wooorm merged commit 6cd9ae4 into mdx-js:main Feb 13, 2024
6 checks passed
@wooorm wooorm added 📚 area/docs This affects documentation 💪 phase/solved Post is done labels Feb 13, 2024
@wooorm
Copy link
Member

wooorm commented Feb 13, 2024

Thanks!

@ChristianMurphy ChristianMurphy deleted the docs/annotated-sponsor-links-with-rel-sponsored branch February 13, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📚 area/docs This affects documentation 💪 phase/solved Post is done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants