Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recma-mdx-change-props, recma-mdx-escape-missing-components to list of plugins #2442

Merged
merged 2 commits into from Feb 20, 2024
Merged

Conversation

talatkuyuk
Copy link
Contributor

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and couldn’t find anything (or linked relevant results below)
  • If applicable, I’ve added docs and tests

Description of changes

Added two new recma plugins into the docs:

Copy link

vercel bot commented Feb 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mdx ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 20, 2024 10:44am

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (908ff45) 100.00% compared to head (4a2d3ef) 100.00%.
Report is 9 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #2442   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           23        23           
  Lines         2693      2694    +1     
  Branches         2         2           
=========================================
+ Hits          2693      2694    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@talatkuyuk
Copy link
Contributor Author

I added a warning for the plugin recma-mdx-change-props into the README.md.

Warning

It is useful for next-mdx-remote or next-mdx-remote-client users in nextjs applications.

@ChristianMurphy
Copy link
Member

Hey @talatkuyuk! 👋
Thanks for sharing!

Have you made the visibility of https://github.com/ipikuka/recma-mdx-change-props public? I'm seeing a 404 not found error when I try to view this link.

@talatkuyuk
Copy link
Contributor Author

talatkuyuk commented Feb 19, 2024

Hey @talatkuyuk! 👋 Thanks for sharing!

Have you made the visibility of https://github.com/ipikuka/recma-mdx-change-props public? I'm seeing a 404 not found error when I try to view this link.

Sorry, I've made it public, now.

Copy link
Member

@ChristianMurphy ChristianMurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @talatkuyuk!

docs/docs/extending-mdx.mdx Outdated Show resolved Hide resolved
docs/docs/extending-mdx.mdx Outdated Show resolved Hide resolved
Signed-off-by: Titus <tituswormer@gmail.com>
@wooorm wooorm changed the title Add two new recma plugins into the docs Add recma-mdx-change-props, recma-mdx-escape-missing-components to list of plugins Feb 20, 2024
@wooorm wooorm merged commit 8f754f7 into mdx-js:main Feb 20, 2024
5 checks passed
@wooorm
Copy link
Member

wooorm commented Feb 20, 2024

Thank you, Talat!

@wooorm wooorm added 📚 area/docs This affects documentation 💪 phase/solved Post is done labels Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📚 area/docs This affects documentation 💪 phase/solved Post is done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants