Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Condensed the hero's heading in 2 lines instead of 3 #2481

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yamanidev
Copy link

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and couldn’t find anything (or linked relevant results below)
  • If applicable, I’ve added docs and tests

Description

I noticed that the heading of the hero section is spanning in 3 lines, leaving quite some blank in the 2nd line. I thought that condensing it to 2 lines would result in a much better and cleaner layout, hence this PR.

Before:
Screenshot from 2024-05-08 14-54-03

After:
Screenshot from 2024-05-08 14-54-17

I'd love to hear your thoughts about this.

Changes

I decreased the font size of the heading from 6rem (or 108px) to 5.9rem (or 106.2px).

Copy link

vercel bot commented May 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mdx ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2024 2:29pm

@wooorm
Copy link
Member

wooorm commented May 8, 2024

Please share more of what you are seeing and why. I cannot reproduce:

Screenshot 2024-05-08 at 5 37 08 PM

@yamanidev
Copy link
Author

I didn't change anything to get the screenshot I shared, that's how it looked on my machine:

  • Screenshots taken from Google Chrome 124.0.6367.60 on Linux (although I get same result on Firefox and Brave)
  • 4k screen with 200% scale

image

I just visited the website on Gnome Web (WebKit based browser) and it looks just fine:
image

@remcohaszing
Copy link
Member

I’m seeing this too on Chrome Linux, but only if the window width is greater than 1215px.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants